Re: [PATCH] checkpatch: Add test for printf formats with 0x that emit decimal

2014-08-04 Thread Hans Wennborg
On 08/03/2014 08:46 PM, Joe Perches wrote: On Sun, 2014-08-03 at 20:03 -0700, Hans Wennborg wrote: On 08/03/2014 07:50 PM, Joe Perches wrote: 0x% should be used to emit hexadecimal values. Uses of 0x%[udi] emit decimal values but these should probably instead use 0x%x variants. Warn on these

Re: [PATCH] checkpatch: Add test for printf formats with 0x that emit decimal

2014-08-03 Thread Joe Perches
On Sun, 2014-08-03 at 20:03 -0700, Hans Wennborg wrote: > On 08/03/2014 07:50 PM, Joe Perches wrote: > > 0x% should be used to emit hexadecimal values. > > > > Uses of 0x%[udi] emit decimal values but these should > > probably instead use 0x%x variants. > > > > Warn on these uses. > > Good idea! [

Re: [PATCH] checkpatch: Add test for printf formats with 0x that emit decimal

2014-08-03 Thread Hans Wennborg
On 08/03/2014 07:50 PM, Joe Perches wrote: 0x% should be used to emit hexadecimal values. Uses of 0x%[udi] emit decimal values but these should probably instead use 0x%x variants. Warn on these uses. Good idea! Signed-off-by: Joe Perches Noticed-by: Hans Wennborg --- scripts/checkpatch