Re: [PATCH] char: xillybus: use devm_add_action_or_reset

2016-04-30 Thread Sudip Mukherjee
On Tue, Apr 26, 2016 at 01:23:08PM +0300, Eli Billauer wrote: > Thanks, > > I like the direction, however both xilly_map_single_* functions turn > out ending with > > if (rc) > return rc; > > return 0; > > Which is equivalent to just "return rc". Or maybe return the value > of t

Re: [PATCH] char: xillybus: use devm_add_action_or_reset

2016-04-26 Thread Eli Billauer
Thanks, I like the direction, however both xilly_map_single_* functions turn out ending with if (rc) return rc; return 0; Which is equivalent to just "return rc". Or maybe return the value of the devm_add_action_or_reset() call directly, and remove the "rc" variable? I don'