Re: [PATCH] cgroup: print pretty format in /proc/cgroups

2014-04-15 Thread Zhan Jianyu
On Tue, Apr 15, 2014 at 8:51 PM, Tejun Heo wrote: > The problem there is that there could be programs / scripts parsing it > assuming single tab between entries. It surely is ugly but do we > care? Oh, you are right. It is an exposed user interface. This will make lots of administrator unhappy ;

Re: [PATCH] cgroup: print pretty format in /proc/cgroups

2014-04-15 Thread Daniel P. Berrange
On Tue, Apr 15, 2014 at 08:47:45PM +0800, Jianyu Zhan wrote: > I found that /proc/cgroups printed format has ugly alignment(see below). [snip] > diff --git a/kernel/cgroup.c b/kernel/cgroup.c > index 9fcdaa7..d981697 100644 > --- a/kernel/cgroup.c > +++ b/kernel/cgroup.c > @@ -4347,7 +4347,7 @@ s

Re: [PATCH] cgroup: print pretty format in /proc/cgroups

2014-04-15 Thread Tejun Heo
On Tue, Apr 15, 2014 at 08:47:45PM +0800, Jianyu Zhan wrote: > I found that /proc/cgroups printed format has ugly alignment(see below). > > This patch confines every field in fixed-width(16 actually) range. > Though MAX_CGROUP_TYPE_NAMELEN is 32, but currently no subsystem > has name width more th