Re: [PATCH] cfq-iosched: handle failure of cfq group allocation

2015-02-09 Thread Jens Axboe
On 02/09/2015 06:42 AM, Konstantin Khlebnikov wrote: Cfq_lookup_create_cfqg() allocates struct blkcg_gq using GFP_ATOMIC. In cfq_find_alloc_queue() possible allocation failure is not handled. As a result kernel oopses on NULL pointer dereference when cfq_link_cfqq_cfqg() calls cfqg_get() for NULL

Re: [PATCH] cfq-iosched: handle failure of cfq group allocation

2015-02-09 Thread Vivek Goyal
On Mon, Feb 09, 2015 at 04:42:49PM +0300, Konstantin Khlebnikov wrote: > Cfq_lookup_create_cfqg() allocates struct blkcg_gq using GFP_ATOMIC. > In cfq_find_alloc_queue() possible allocation failure is not handled. > As a result kernel oopses on NULL pointer dereference when > cfq_link_cfqq_cfqg() c

Re: [PATCH] cfq-iosched: handle failure of cfq group allocation

2015-02-09 Thread Tejun Heo
On Mon, Feb 09, 2015 at 04:42:49PM +0300, Konstantin Khlebnikov wrote: > Cfq_lookup_create_cfqg() allocates struct blkcg_gq using GFP_ATOMIC. > In cfq_find_alloc_queue() possible allocation failure is not handled. > As a result kernel oopses on NULL pointer dereference when > cfq_link_cfqq_cfqg() c