Re: [PATCH] brcmfmac: unlink URB when request timed out

2014-11-11 Thread Oliver Neukum
On Tue, 2014-11-11 at 20:02 -0500, Mathy Vanhoef wrote: > On 11/10/2014 04:08 AM, Oliver Neukum wrote: > > Which means that you are freeing memory that may still be used by DMA > > at this time. > > In addition you have no guarantee that the unlink is indeed finished > > by the time the URB is reu

Re: [PATCH] brcmfmac: unlink URB when request timed out

2014-11-11 Thread Mathy Vanhoef
On 11/10/2014 04:08 AM, Oliver Neukum wrote: > On Sun, 2014-11-09 at 13:10 -0500, Mathy Vanhoef wrote: >> From: Mathy Vanhoef >> >> Unlink the submitted URB in brcmf_usb_dl_cmd if the request timed out. This >> assures the URB is never submitted twice, preventing a driver crash. > > Hi, > > I am a

Re: [PATCH] brcmfmac: unlink URB when request timed out

2014-11-10 Thread Oliver Neukum
On Sun, 2014-11-09 at 13:10 -0500, Mathy Vanhoef wrote: > From: Mathy Vanhoef > > Unlink the submitted URB in brcmf_usb_dl_cmd if the request timed out. This > assures the URB is never submitted twice, preventing a driver crash. Hi, I am afrad this patch is no good. The diagnosis is good, but t