Re: [PATCH] brcmfmac: Do not crash if platform data is not populated

2014-12-24 Thread Kalle Valo
Mika Westerberg writes: > The driver looks for pdata->oob_irq_supported to find out if wowl can be > supported. However, not all platforms populate pdata in which case we crash > the kernel because of NULL pointer dereference. > > Fixes: 330b4e4be937 ("brcmfmac: Add wowl support for SDIO devices.

Re: [PATCH] brcmfmac: Do not crash if platform data is not populated

2014-12-23 Thread Arend van Spriel
On 12/23/14 18:00, Kalle Valo wrote: Arend van Spriel writes: On 12/23/14 16:47, Mika Westerberg wrote: On Tue, Dec 23, 2014 at 04:37:21PM +0100, Arend van Spriel wrote: On 12/23/14 15:48, Mika Westerberg wrote: The driver looks for pdata->oob_irq_supported to find out if wowl can be suppor

Re: [PATCH] brcmfmac: Do not crash if platform data is not populated

2014-12-23 Thread Kalle Valo
Arend van Spriel writes: > On 12/23/14 16:47, Mika Westerberg wrote: >> On Tue, Dec 23, 2014 at 04:37:21PM +0100, Arend van Spriel wrote: >>> On 12/23/14 15:48, Mika Westerberg wrote: The driver looks for pdata->oob_irq_supported to find out if wowl can be supported. However, not all pl

Re: [PATCH] brcmfmac: Do not crash if platform data is not populated

2014-12-23 Thread Arend van Spriel
On 12/23/14 16:47, Mika Westerberg wrote: On Tue, Dec 23, 2014 at 04:37:21PM +0100, Arend van Spriel wrote: On 12/23/14 15:48, Mika Westerberg wrote: The driver looks for pdata->oob_irq_supported to find out if wowl can be supported. However, not all platforms populate pdata in which case we cr

Re: [PATCH] brcmfmac: Do not crash if platform data is not populated

2014-12-23 Thread Mika Westerberg
On Tue, Dec 23, 2014 at 04:37:21PM +0100, Arend van Spriel wrote: > On 12/23/14 15:48, Mika Westerberg wrote: > >The driver looks for pdata->oob_irq_supported to find out if wowl can be > >supported. However, not all platforms populate pdata in which case we crash > >the kernel because of NULL poin

Re: [PATCH] brcmfmac: Do not crash if platform data is not populated

2014-12-23 Thread Arend van Spriel
On 12/23/14 15:48, Mika Westerberg wrote: The driver looks for pdata->oob_irq_supported to find out if wowl can be supported. However, not all platforms populate pdata in which case we crash the kernel because of NULL pointer dereference. Thanks, Mika However, this was already reported by Dan