Re: [PATCH] bracing the loop in kernel/softirq.c

2007-06-22 Thread Jeremy Fitzhardinge
Cyrill Gorcunov wrote: Btw, Jeremy, could you please Ack it then and I'll resend the patch to Andrew ;) Not sure its worth a patch to just change that on its own. Fix it in passing if it needs changing anyway, or generate a patch to fix them all. But I can't see Andrew being very keen on

Re: [PATCH] bracing the loop in kernel/softirq.c

2007-06-22 Thread Cyrill Gorcunov
[Jeremy Fitzhardinge - Thu, Jun 21, 2007 at 11:52:25AM -0700] > Jesper Juhl wrote: >> On 20/06/07, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: >>> This trivial patch adds braces over a one-line >>> loop. That makes code...well... little bit >>> convenient for (possible) further modifications. >>> >>

Re: [PATCH] bracing the loop in kernel/softirq.c

2007-06-22 Thread Cyrill Gorcunov
[Jeremy Fitzhardinge - Thu, Jun 21, 2007 at 11:52:25AM -0700] > Jesper Juhl wrote: >> On 20/06/07, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: >>> This trivial patch adds braces over a one-line >>> loop. That makes code...well... little bit >>> convenient for (possible) further modifications. >>> >>

Re: [PATCH] bracing the loop in kernel/softirq.c

2007-06-21 Thread Jeremy Fitzhardinge
Jesper Juhl wrote: On 20/06/07, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: This trivial patch adds braces over a one-line loop. That makes code...well... little bit convenient for (possible) further modifications. That's generally not done. It's even in Documentation/CodingStyle : " Do not u

Re: [PATCH] bracing the loop in kernel/softirq.c

2007-06-21 Thread Cyrill Gorcunov
[Jesper Juhl - Thu, Jun 21, 2007 at 07:20:33PM +0200] | From: Jesper Juhl <[EMAIL PROTECTED]> | To: Cyrill Gorcunov <[EMAIL PROTECTED]> | Cc: LKML | Subject: Re: [PATCH] bracing the loop in kernel/softirq.c | Date: Thu, 21 Jun 2007 19:20:33 +0200 | > On 21/06/07, Cyrill G

Re: [PATCH] bracing the loop in kernel/softirq.c

2007-06-21 Thread Jesper Juhl
On 21/06/07, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: [Jesper Juhl - Wed, Jun 20, 2007 at 11:01:44PM +0200] | From: Jesper Juhl <[EMAIL PROTECTED]> | To: Cyrill Gorcunov <[EMAIL PROTECTED]> | Cc: LKML | Subject: Re: [PATCH] bracing the loop in kernel/softirq.c | Date: Wed,

Re: [PATCH] bracing the loop in kernel/softirq.c

2007-06-21 Thread Cyrill Gorcunov
[Jesper Juhl - Wed, Jun 20, 2007 at 11:01:44PM +0200] | From: Jesper Juhl <[EMAIL PROTECTED]> | To: Cyrill Gorcunov <[EMAIL PROTECTED]> | Cc: LKML | Subject: Re: [PATCH] bracing the loop in kernel/softirq.c | Date: Wed, 20 Jun 2007 23:01:44 +0200 | > On 20/06/07, Cyrill G

Re: [PATCH] bracing the loop in kernel/softirq.c

2007-06-20 Thread Jesper Juhl
On 20/06/07, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: This trivial patch adds braces over a one-line loop. That makes code...well... little bit convenient for (possible) further modifications. That's generally not done. It's even in Documentation/CodingStyle : " Do not unnecessarily use bra