Re: [PATCH] block: Use BIT macro from include/linux/bitops.h

2015-05-20 Thread Jens Axboe
On 05/20/2015 01:50 PM, Jagan Teki wrote: On 21 May 2015 at 01:13, Jens Axboe wrote: On 05/20/2015 01:41 PM, Jagan Teki wrote: On 21 May 2015 at 00:52, Jens Axboe wrote: On 05/18/2015 01:14 PM, Jagan Teki wrote: Replace (1 << nr) to BIT(nr) where nr = 0, 1, 2 31 I don't like it

Re: [PATCH] block: Use BIT macro from include/linux/bitops.h

2015-05-20 Thread Jagan Teki
On 21 May 2015 at 01:13, Jens Axboe wrote: > On 05/20/2015 01:41 PM, Jagan Teki wrote: >> >> On 21 May 2015 at 00:52, Jens Axboe wrote: >>> >>> On 05/18/2015 01:14 PM, Jagan Teki wrote: Replace (1 << nr) to BIT(nr) where nr = 0, 1, 2 31 >>> >>> >>> >>> I don't like it, I think

Re: [PATCH] block: Use BIT macro from include/linux/bitops.h

2015-05-20 Thread Jens Axboe
On 05/20/2015 01:41 PM, Jagan Teki wrote: On 21 May 2015 at 00:52, Jens Axboe wrote: On 05/18/2015 01:14 PM, Jagan Teki wrote: Replace (1 << nr) to BIT(nr) where nr = 0, 1, 2 31 I don't like it, I think it hurts readability. What do you mean by don't like, using kernel defined macro

Re: [PATCH] block: Use BIT macro from include/linux/bitops.h

2015-05-20 Thread Jagan Teki
On 21 May 2015 at 00:52, Jens Axboe wrote: > On 05/18/2015 01:14 PM, Jagan Teki wrote: >> >> Replace (1 << nr) to BIT(nr) where nr = 0, 1, 2 31 > > > I don't like it, I think it hurts readability. What do you mean by don't like, using kernel defined macro instead of numerical assignments hut

Re: [PATCH] block: Use BIT macro from include/linux/bitops.h

2015-05-20 Thread Jens Axboe
On 05/18/2015 01:14 PM, Jagan Teki wrote: Replace (1 << nr) to BIT(nr) where nr = 0, 1, 2 31 I don't like it, I think it hurts readability. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] block: Use BIT macro from include/linux/bitops.h

2015-05-20 Thread Jagan Teki
Ping! On 19 May 2015 at 00:44, Jagan Teki wrote: > Replace (1 << nr) to BIT(nr) where nr = 0, 1, 2 31 > > Signed-off-by: Jagan Teki > Cc: Wolfram Sang > Cc: Jens Axboe > --- > drivers/block/mg_disk.c | 10 +- > drivers/block/mtip32xx/mtip32xx.c | 14 +++--- > dr