Re: [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in make_class_name(). USB maintainers can try this themselves, by plugging in an external USB XX-in-1 flash reader, with a CF card inserted. Then just jiggle the

Re: [PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-29 Thread Mark Lord
Mark Lord wrote: Mark Lord wrote: ... And here is a "prevented" oops, courtesy of the patch (2.6.23.8). These are easy to reproduce (just jiggle the connection on an attached USB multi-card reader with a CF card inserted): ... [ 347.099562] usb 5-6: USB disconnect, address 10 [ 347.101077] BU

Re: [PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-29 Thread Mark Lord
Mark Lord wrote: (reposting for linux-usb-devel list) Greg KH wrote: On Wed, Nov 28, 2007 at 11:00:36PM -0500, Mark Lord wrote: While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on the call to strlen() in make_class_name(). This patch prevents this oop

Re: [PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 10:41:29AM -0500, Mark Lord wrote: > Greg KH wrote: >> On Wed, Nov 28, 2007 at 11:00:36PM -0500, Mark Lord wrote: >>> While doing insert/remove (quickly) tests on USB, I managed to trigger >>> an Oops on 2.6.23.1 on the call to strlen() in make_class_name(). >>> >>> This pat

Re: [PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-29 Thread Mark Lord
Greg KH wrote: On Wed, Nov 28, 2007 at 11:00:36PM -0500, Mark Lord wrote: While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.1 on the call to strlen() in make_class_name(). This patch prevents this oops. There is still the larger problem of the overall rac

Re: [PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-28 Thread Greg KH
On Wed, Nov 28, 2007 at 11:00:36PM -0500, Mark Lord wrote: > While doing insert/remove (quickly) tests on USB, I managed to trigger > an Oops on 2.6.23.1 on the call to strlen() in make_class_name(). > > This patch prevents this oops. > > There is still the larger problem of the overall race > that