Re: [PATCH] audit: wait_for_auditd() should use TASK_UNINTERRUPTIBLE

2013-05-31 Thread Oleg Nesterov
On 05/29, Andrew Morton wrote: > > On Fri, 24 May 2013 19:39:25 +0200 Oleg Nesterov wrote: > > > audit_log_start() does wait_for_auditd() in a loop until > > audit_backlog_wait_time passes or audit_skb_queue has a room. > > > > If signal_pending() is true this becomes a busy-wait loop, > > schedul

Re: [PATCH] audit: wait_for_auditd() should use TASK_UNINTERRUPTIBLE

2013-05-29 Thread Guy Streeter
On 05/29/2013 04:59 PM, Andrew Morton wrote: > On Fri, 24 May 2013 19:39:25 +0200 Oleg Nesterov wrote: > >> audit_log_start() does wait_for_auditd() in a loop until >> audit_backlog_wait_time passes or audit_skb_queue has a room. >> >> If signal_pending() is true this becomes a busy-wait loop, >>

Re: [PATCH] audit: wait_for_auditd() should use TASK_UNINTERRUPTIBLE

2013-05-29 Thread Andrew Morton
On Fri, 24 May 2013 19:39:25 +0200 Oleg Nesterov wrote: > audit_log_start() does wait_for_auditd() in a loop until > audit_backlog_wait_time passes or audit_skb_queue has a room. > > If signal_pending() is true this becomes a busy-wait loop, > schedule() in TASK_INTERRUPTIBLE won't block. And t

Re: [PATCH] audit: wait_for_auditd() should use TASK_UNINTERRUPTIBLE

2013-05-24 Thread Oleg Nesterov
On 05/24, Oleg Nesterov wrote: > > audit_log_start() does wait_for_auditd() in a loop until > audit_backlog_wait_time passes or audit_skb_queue has a room. > > If signal_pending() is true this becomes a busy-wait loop, > schedule() in TASK_INTERRUPTIBLE won't block. And the code looks strange imho