Re: [PATCH] audit: remove unused macros

2020-11-24 Thread Paul Moore
On Wed, Nov 11, 2020 at 7:38 PM Alex Shi wrote: > From 5fef5f1b7b745b52bedc9c7eec9fc163202ad421 Mon Sep 17 00:00:00 2001 > From: Alex Shi > Date: Fri, 6 Nov 2020 16:31:22 +0800 > Subject: [PATCH v3] audit: fix macros warnings > > Some unused macros could cause gcc warning: > kernel/audit.c:68:0:

Re: [PATCH] audit: remove unused macros

2020-11-11 Thread Alex Shi
在 2020/11/11 下午9:17, Richard Guy Briggs 写道: >> >> audit_filter_syscall(tsk, context, > This all looks good, but I don't see the initialization of > context->return_valid in audit_alloc_context() that was mentioned for > completeness. > Sorry for missing that. Here they are. >Fr

Re: [PATCH] audit: remove unused macros

2020-11-11 Thread Richard Guy Briggs
On 2020-11-11 14:19, Alex Shi wrote: > Thanks for comments! > So here is the v2 according to your suggestion! > > From 033425b6072ff4cee05d6bbffc97cd6a4c13166c Mon Sep 17 00:00:00 2001 > From: Alex Shi > Date: Fri, 6 Nov 2020 16:31:22 +0800 > Subject: [PATCH v2] kernel/audit: fix macros warning >

Re: [PATCH] audit: remove unused macros

2020-11-10 Thread Alex Shi
Thanks for comments! So here is the v2 according to your suggestion! >From 033425b6072ff4cee05d6bbffc97cd6a4c13166c Mon Sep 17 00:00:00 2001 From: Alex Shi Date: Fri, 6 Nov 2020 16:31:22 +0800 Subject: [PATCH v2] kernel/audit: fix macros warning Some unused macros could cause gcc warning: kernel

Re: [PATCH] audit: remove unused macros

2020-11-10 Thread Richard Guy Briggs
On 2020-11-10 21:47, Paul Moore wrote: > On Tue, Nov 10, 2020 at 10:23 AM Richard Guy Briggs wrote: > > On 2020-11-06 16:31, Alex Shi wrote: > > > Some unused macros could cause gcc warning: > > > kernel/audit.c:68:0: warning: macro "AUDIT_UNINITIALIZED" is not used > > > [-Wunused-macros] > > > k

Re: [PATCH] audit: remove unused macros

2020-11-10 Thread Paul Moore
On Tue, Nov 10, 2020 at 10:23 AM Richard Guy Briggs wrote: > On 2020-11-06 16:31, Alex Shi wrote: > > Some unused macros could cause gcc warning: > > kernel/audit.c:68:0: warning: macro "AUDIT_UNINITIALIZED" is not used > > [-Wunused-macros] > > kernel/auditsc.c:104:0: warning: macro "AUDIT_AUX_IP

Re: [PATCH] audit: remove unused macros

2020-11-10 Thread Richard Guy Briggs
On 2020-11-06 16:31, Alex Shi wrote: > Some unused macros could cause gcc warning: > kernel/audit.c:68:0: warning: macro "AUDIT_UNINITIALIZED" is not used > [-Wunused-macros] > kernel/auditsc.c:104:0: warning: macro "AUDIT_AUX_IPCPERM" is not used > [-Wunused-macros] > kernel/auditsc.c:82:0: warnin