Re: [PATCH] arm64: csum: cast to the proper type

2021-03-15 Thread Will Deacon
On Sun, 14 Mar 2021 20:26:50 -0500, Alex Elder wrote: > The last line of ip_fast_csum() calls csum_fold(), forcing the > type of the argument passed to be u32. But csum_fold() takes a > __wsum argument (which is __u32 __bitwise for arm64). As long > as we're forcing the cast, cast it to the right

Re: [PATCH] arm64: csum: cast to the proper type

2021-03-15 Thread Robin Murphy
On 2021-03-15 01:26, Alex Elder wrote: The last line of ip_fast_csum() calls csum_fold(), forcing the type of the argument passed to be u32. But csum_fold() takes a __wsum argument (which is __u32 __bitwise for arm64). As long as we're forcing the cast, cast it to the right type. Oddly, the c