Re: [PATCH] arm: dma-mapping: fix compilation error when CONFIG_MMU is not present

2014-10-27 Thread Marek Szyprowski
Hello, On 2014-10-24 15:15, Stefan Hengelein wrote: Hello, adding a dependency to CONFIG_ARM_DMA_USE_IOMMU is probably not a good idea anyways. If you read the Documentation/kbuild/kconfig-language.txt, you will see that: 1. in general, selected options should have no prompt and no dependencies

Re: [PATCH] arm: dma-mapping: fix compilation error when CONFIG_MMU is not present

2014-10-24 Thread Stefan Hengelein
Hello, adding a dependency to CONFIG_ARM_DMA_USE_IOMMU is probably not a good idea anyways. If you read the Documentation/kbuild/kconfig-language.txt, you will see that: 1. in general, selected options should have no prompt and no dependencies 2. giving ARM_DMA_USE_IOMMU a dependency on MMU will a

Re: [PATCH] arm: dma-mapping: fix compilation error when CONFIG_MMU is not present

2014-10-23 Thread Marek Szyprowski
Hello, On 2014-10-21 02:05, Laura Abbott wrote: On 10/20/2014 6:50 AM, Stefan Hengelein wrote: Well, arch/arm/mm/dma-mapping.c: In function ‘__atomic_get_pages’: arch/arm/mm/dma-mapping.c:1265:31: error: ‘atomic_pool’ undeclared (first use in this function) arch/arm/mm/dma-mapping.c: In funct

Re: [PATCH] arm: dma-mapping: fix compilation error when CONFIG_MMU is not present

2014-10-20 Thread Laura Abbott
On 10/20/2014 6:50 AM, Stefan Hengelein wrote: Well, arch/arm/mm/dma-mapping.c: In function ‘__atomic_get_pages’: arch/arm/mm/dma-mapping.c:1265:31: error: ‘atomic_pool’ undeclared (first use in this function) arch/arm/mm/dma-mapping.c: In function ‘__iommu_get_pages’: arch/arm/mm/dma-mapping.c

Re: [PATCH] arm: dma-mapping: fix compilation error when CONFIG_MMU is not present

2014-10-20 Thread Marek Szyprowski
Hello, On 2014-10-19 17:59, Stefan Hengelein wrote: When CONFIG_MMU is not present, the variable 'atomic_pool' and the function '__in_atomic_pool' are undeclared but used in part of the code. Therefore, the compilation breaks. Now, they are defined to dummy values when CONFIG_MMU is undefined.