Re: [PATCH] arch/x86/boot: sizeof macro

2018-01-08 Thread H. Peter Anvin
On 01/06/18 03:50, Ingo Molnar wrote: > > We probably don't want to change then, and my point was that 99.8% of the > current > usage is as a 'function': > > triton:~/tip> git grep 'sizeof(' | wc -l > 116570 > > triton:~/tip> git grep 'sizeof [:alnum:]' | wc -l > 177 > > i.e. your pat

Re: [PATCH] arch/x86/boot: sizeof macro

2018-01-06 Thread Ingo Molnar
* Andy Shevchenko wrote: > On Fri, Dec 29, 2017 at 9:46 PM, Ingo Molnar wrote: > > * Andy Shevchenko wrote: > > >> > - ireg.cx = sizeof buf; > >> > + ireg.cx = sizeof(buf); > >> > >> sizeof is operator, not a function. > >> So, what are you trying to achieve? > > > > That's true

Re: [PATCH] arch/x86/boot: sizeof macro

2017-12-31 Thread Joe Perches
On Sun, 2017-12-31 at 13:48 +0200, Andy Shevchenko wrote: > On Fri, Dec 29, 2017 at 9:46 PM, Ingo Molnar wrote: > > * Andy Shevchenko wrote: > > > > - ireg.cx = sizeof buf; > > > > + ireg.cx = sizeof(buf); > > > > > > sizeof is operator, not a function. > > > So, what are you tryin

Re: [PATCH] arch/x86/boot: sizeof macro

2017-12-31 Thread Andy Shevchenko
On Fri, Dec 29, 2017 at 9:46 PM, Ingo Molnar wrote: > * Andy Shevchenko wrote: >> > - ireg.cx = sizeof buf; >> > + ireg.cx = sizeof(buf); >> >> sizeof is operator, not a function. >> So, what are you trying to achieve? > > That's true, but in the kernel coding style we use it as a

Re: [PATCH] arch/x86/boot: sizeof macro

2017-12-29 Thread Ingo Molnar
* Andy Shevchenko wrote: > On Fri, Dec 29, 2017 at 8:30 PM, Saidgani Musaev wrote: > > No changelog, no explanation why... > No SoB tag... > > > - ireg.cx = sizeof buf; > > + ireg.cx = sizeof(buf); > > sizeof is operator, not a function. > So, what are you trying to achieve? T

Re: [PATCH] arch/x86/boot: sizeof macro

2017-12-29 Thread hacku
Coding style for sizeof . If you check this file with checkpatch.pl you will see warning on this line. Yes, sorry I didn't mark this change as a coding style issue. best regards, Saidgani. On 12/29/2017 07:41 PM, Andy Shevchenko wrote: On Fri, Dec 29, 2017 at 8:30 PM, Saidgani Musaev wrote:

Re: [PATCH] arch/x86/boot: sizeof macro

2017-12-29 Thread Andy Shevchenko
On Fri, Dec 29, 2017 at 8:30 PM, Saidgani Musaev wrote: No changelog, no explanation why... No SoB tag... > - ireg.cx = sizeof buf; > + ireg.cx = sizeof(buf); sizeof is operator, not a function. So, what are you trying to achieve? -- With Best Regards, Andy Shevchenko