Re: [PATCH] apple-gmux: Fix kconfig dependencies

2012-08-02 Thread Randy Dunlap
On 08/02/2012 10:15 AM, Seth Forshee wrote: > Fix the dependencies of apple-gmux to prevent it from being built-in > when one or more of its dependencies is built as a module. Otherwise it > can fail to build due to missing symbols. > > v2: Add dependency on ACPI to fix build failure when ACPI=n

Re: [PATCH] apple-gmux: Fix kconfig dependencies

2012-07-23 Thread Seth Forshee
On Mon, Jul 23, 2012 at 08:28:05AM -0700, Randy Dunlap wrote: > On 07/23/2012 06:44 AM, Seth Forshee wrote: > > > On Mon, Jul 23, 2012 at 02:30:10PM +0100, Matthew Garrett wrote: > >>> I'm looking at Andreas's code for switcharoo support, and something I > >>> want to do along with it is make appl

Re: [PATCH] apple-gmux: Fix kconfig dependencies

2012-07-23 Thread Randy Dunlap
On 07/23/2012 06:44 AM, Seth Forshee wrote: > On Mon, Jul 23, 2012 at 02:30:10PM +0100, Matthew Garrett wrote: >>> I'm looking at Andreas's code for switcharoo support, and something I >>> want to do along with it is make apple-gmux not dependent on backlight >>> support (i.e. you can still build

Re: [PATCH] apple-gmux: Fix kconfig dependencies

2012-07-23 Thread Seth Forshee
On Mon, Jul 23, 2012 at 02:30:10PM +0100, Matthew Garrett wrote: > > I'm looking at Andreas's code for switcharoo support, and something I > > want to do along with it is make apple-gmux not dependent on backlight > > support (i.e. you can still build switcharoo support if > > BACKLIGHT_CLASS_DEVIC

Re: [PATCH] apple-gmux: Fix kconfig dependencies

2012-07-23 Thread Matthew Garrett
On Mon, Jul 16, 2012 at 04:50:34PM -0700, Seth Forshee wrote: > On Mon, Jul 02, 2012 at 09:55:29AM -0500, Seth Forshee wrote: > > Fix the dependencies of apple-gmux to prevent it from being built-in > > when one or more of its dependencies is built as a module. Otherwise it > > can fail to build du

Re: [PATCH] apple-gmux: Fix kconfig dependencies

2012-07-16 Thread Seth Forshee
On Mon, Jul 02, 2012 at 09:55:29AM -0500, Seth Forshee wrote: > Fix the dependencies of apple-gmux to prevent it from being built-in > when one or more of its dependencies is built as a module. Otherwise it > can fail to build due to missing symbols. Matthew: Are you okay with this, or is there so