Re: [PATCH] alarmtimer: Add the verification code for rtc device error.

2014-08-06 Thread Hyogi Gim
On 07/31/2014 02:58 AM, John Stultz wrote: > > Hey! Sorry for the late response here. > > So this seems reasonable as always failing suspend is problematic, but > I worry that for the case where we do have a failure to read or set > the RTC, we'd suspend and not wake up as specified, which is a

Re: [PATCH] alarmtimer: Add the verification code for rtc device error.

2014-07-30 Thread John Stultz
On Thu, Jul 10, 2014 at 6:24 PM, Hyogi Gim wrote: > In alarmtimer_suspend(), the error after rtc_read_time() is not checked. > If rtc device fail to read rtc time, we cannot ensure the following process. > > Furthermore, the return value of rtc_timer_start() needs to distinguish > -ETIME and other