Re: [PATCH] aio: fix potential leak in aio_run_iocb().

2014-05-02 Thread Lukáš Czerner
On Thu, 1 May 2014, Leon Yu wrote: > Date: Thu, 1 May 2014 03:31:28 + > From: Leon Yu > To: Benjamin LaHaise , > Alexander Viro > Cc: linux-...@kvack.org, linux-fsde...@vger.kernel.org, > linux-kernel@vger.kernel.org, Leon Yu > Subject: [PATCH] aio: fix potential leak in aio_run_io

Re: [PATCH] aio: fix potential leak in aio_run_iocb().

2014-05-01 Thread Benjamin LaHaise
On Thu, May 01, 2014 at 03:31:28AM +, Leon Yu wrote: > iovec should be reclaimed whenever caller of rw_copy_check_uvector() returns, > but it doesn't hold when failure happens right after aio_setup_vectored_rw(). > > Fix that in a such way to avoid hairy goto. Good catch -- applied.

Re: [PATCH] aio: fix potential leak in aio_run_iocb().

2014-04-30 Thread Mateusz Guzik
On Thu, May 01, 2014 at 03:31:28AM +, Leon Yu wrote: > iovec should be reclaimed whenever caller of rw_copy_check_uvector() returns, > but it doesn't hold when failure happens right after aio_setup_vectored_rw(). > There is a proposal (wich a patch) to modify semantics of rw_copy_check_uvecto