Geert Uytterhoeven wrote:
> On Tue, 29 May 2007, Andy Whitcroft wrote:
>> As a first step package up the current state of the patch style
>> checker and include it in the kernel tree. Add instructions
>> suggesting running it on submissions. This adds version v0.01 of
>
On Wed, Jun 06, 2007 at 02:40:24PM +0200, Geert Uytterhoeven wrote:
> Will http://www.codemonkey.org.uk/projects/checkpatch/checkpatch.git/ (hey, a
> project with the same name started by the same person???) be merged in?
Andy and I were working on this in parallel with the same goal.
When his
On Tue, 29 May 2007, Andy Whitcroft wrote:
> As a first step package up the current state of the patch style
> checker and include it in the kernel tree. Add instructions
> suggesting running it on submissions. This adds version v0.01 of
Dave Jones wrote:
> On Thu, May 31, 2007 at 02:07:53PM +0200, Andi Kleen wrote:
> > > Yeah, that is a very sensible idea.
> > >
> > > > Possible further checks that might make sense:
> > > > - panic() anywhere in drivers/*
> > > > - externs in .c files without asmlinkage
> > > > - general c
On Thu, May 31, 2007 at 02:07:53PM +0200, Andi Kleen wrote:
> > Yeah, that is a very sensible idea.
> >
> > > Possible further checks that might make sense:
> > > - panic() anywhere in drivers/*
> > > - externs in .c files without asmlinkage
> > > - general checking that everything in a ful
>+sub top_of_kernel_tree {
>+ if ((-f "COPYING") && (-f "CREDITS") && (-f "Kbuild") &&
>+ (-f "MAINTAINERS") && (-f "Makefile") && (-f "README") &&
>+ (-d "Documentation") && (-d "arch") && (-d "include") &&
>+ (-d "drivers") && (-d "fs") && (-d "init") && (-d "ipc"
> Yeah, that is a very sensible idea.
>
> > Possible further checks that might make sense:
> > - panic() anywhere in drivers/*
> > - externs in .c files without asmlinkage
> > - general checking that everything in a fully visible {} block is the right
> > indentation
> >
Here are some more war
On May 30 2007 08:33, Randy Dunlap wrote:
>> > That's just a joe bug then.
>> >
>> > diff no longer requires a beginning space, at least in the testing
>> > that I did it worked with no leading space on a label:.
>>
>> But not everyone runs the latest and greatest. diffutils 2.8.7
>> takes /^lab
Jan Engelhardt wrote:
On May 29 2007 15:36, Randy Dunlap wrote:
+ if($line=~/^\s*[A-Za-z\d_]+:/ and !($line=~/^\s*default:/)){
+ print "Gotos should not be indented\n";
+ print "$herecurr";
+ $clean = 0;
+
> So you prefer random data corruption over an emergency stop?
With an oops you can at least recover the system and actually
look at the problem. On a machine with a panic you're just dead
and the probability of actually being able to do something about the problem
is much lower. On x86 systems y
On May 29 2007 15:36, Randy Dunlap wrote:
>> >>> +if($line=~/^\s*[A-Za-z\d_]+:/ and
>> >>> !($line=~/^\s*default:/)){
>> >>> +print "Gotos should not be indented\n";
>> >>> +print "$herecurr";
>> >>> +$clean =
As a first step package up the current state of the patch style
checker and include it in the kernel tree. Add instructions
suggesting running it on submissions. This adds version v0.01 of
the checkpatch.pl script.
Signed-off-by: Andy Whitcroft <[EMAIL PROTECTED]>
Signed-off-by: Joel Schopp <
On Tue, 29 May 2007 22:22:43 +0200 (MEST) Jan Engelhardt wrote:
>
> On May 29 2007 10:05, Andy Whitcroft wrote:
> >
> >>> + if($line=~/^\s*[A-Za-z\d_]+:/ and !($line=~/^\s*default:/)){
> >>> + print "Gotos should not be indented\n";
> >>> + print "$herecurr
Heiko Carstens <[EMAIL PROTECTED]> writes:
>
> I'm talking of a specific problem where we just added a panic to the
> zfcp device driver. If that panic ever triggers we know for sure that
> memory corruption happened.
> So I'm just asking to not say in general that panic() in a device driver
> is
On May 29 2007 10:05, Andy Whitcroft wrote:
>
>>> + if($line=~/^\s*[A-Za-z\d_]+:/ and !($line=~/^\s*default:/)){
>>> + print "Gotos should not be indented\n";
>>> + print "$herecurr";
>>> + $clean = 0;
>>> + }
>>
>> emacs g
On May 29 2007 10:01, Andy Whitcroft wrote:
>>
>> The consistent style quite looses after this point, esp. space around
>> operators ;-)
>
>Yep thats on my list for cleanup ...
Hey, you might even try running patch-trivia-detector.pl through itself. :)
>> Attention span ran out. :)
>
>Thanks f
Andi Kleen wrote:
>> +# don't include
>
> It would be probably better to define some syntax that makes it possible
> to auto extract those from feature-removal-schedule.txt. Otherwise
> long term this will become messy.
Turns out that we already have Files: entries in f-r-s.txt and so I've
enha
On Tue, May 29, 2007 at 04:58:18PM +0200, Andi Kleen wrote:
> > So you prefer random data corruption over an emergency stop?
>
> With an oops you can at least recover the system and actually
> look at the problem. On a machine with a panic you're just dead
> and the probability of actually being
On 29/05/2007, at 18:12, Joel Schopp wrote:
+ if(!($prevline=~/\/\*\*/) && length($lineforcounting) > 80){
Actually, I think this should be "> 79" (after stripping a .diff's
control column), since the cursor may move to the 81th column when
editing an 80-col line - which is what w
+ if(!($prevline=~/\/\*\*/) && length($lineforcounting) > 80){
Actually, I think this should be "> 79" (after stripping a .diff's
control column), since the cursor may move to the 81th column when
editing an 80-col line - which is what we want to avoid, no?
80 tends to work for me
Randy Dunlap wrote:
On Sun, 27 May 2007 18:11:25 +0100 Andy Whitcroft wrote:
Also if either Joel or Randy want to be on on the MAINTAINERS
entry yell and we'll get it updated, wouldn't want to list
anyone without permission.
Yes, please.
Yes. Add me as well.
-
To u
> > > Possible further checks that might make sense:
> > > - panic() anywhere in drivers/*
> >
> > A driver should be allowed to panic. E.g. if it detects that due to a
> > firmware or driver bug memory corruption happened. IMHO the best thing
> > to do then is panic.
>
> That is not how Linux n
On Tue, May 29, 2007 at 01:53:24PM +0200, Heiko Carstens wrote:
> On Tue, May 29, 2007 at 04:23:45AM +0200, Andi Kleen wrote:
> > Possible further checks that might make sense:
> > - panic() anywhere in drivers/*
>
> A driver should be allowed to panic. E.g. if it detects that due to a
> firmware
On Tue, May 29, 2007 at 04:23:45AM +0200, Andi Kleen wrote:
> Possible further checks that might make sense:
> - panic() anywhere in drivers/*
A driver should be allowed to panic. E.g. if it detects that due to a
firmware or driver bug memory corruption happened. IMHO the best thing
to do then is
Andi Kleen wrote:
> Andy Whitcroft <[EMAIL PROTECTED]> writes:
>> +
>> +# no BUG() or BUG_ON()
>> +if ($line =~ /\b(BUG|BUG_ON)\b/) {
>> +print "Try to use WARN_ON & Recovery code rather than
>> BUG() or BUG_ON()\n";
>
> Just outlawing BUG_ON doesn't seem like a go
Jan Engelhardt wrote:
> On May 27 2007 18:11, Andy Whitcroft wrote:
>> +
>> +my $P = $0;
>> +
>> +my $V = '0.01';
>> +
>> +use Getopt::Long qw(:config no_auto_abbrev);
>> [...]
>> +sub top_of_kernel_tree {
>> +if ((-f "COPYING") && (-f "CREDITS") && (-f "Kbuild") &&
>> +(-f "MAINTAINERS
On 28/05/07, Andy Whitcroft <[EMAIL PROTECTED]> wrote:
...
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index a417b25..23637e8 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -118,7 +118,21 @@ then only post say 15 or so at
Andy Whitcroft <[EMAIL PROTECTED]> writes:
> +
> +# no BUG() or BUG_ON()
> + if ($line =~ /\b(BUG|BUG_ON)\b/) {
> + print "Try to use WARN_ON & Recovery code rather than
> BUG() or BUG_ON()\n";
Just outlawing BUG_ON doesn't seem like a good idea to me. We'll just e
Andrew Morton wrote:
> On Sun, 27 May 2007 18:11:25 +0100 Andy Whitcroft <[EMAIL PROTECTED]> wrote:
>
>> +#gotos aren't indented
>> +if($line=~/^\s*[A-Za-z\d_]+:/ and !($line=~/^\s*default:/)){
>> +print "Gotos should not be indented\n";
>> +prin
Randy Dunlap wrote:
> On Sun, 27 May 2007 18:11:25 +0100 Andy Whitcroft wrote:
>
>> Also if either Joel or Randy want to be on on the MAINTAINERS
>> entry yell and we'll get it updated, wouldn't want to list
>> anyone without permission.
>
> Yes, please.
>
>> I have the infra
On May 27 2007 18:11, Andy Whitcroft wrote:
>+
>+my $P = $0;
>+
>+my $V = '0.01';
>+
>+use Getopt::Long qw(:config no_auto_abbrev);
>[...]
>+sub top_of_kernel_tree {
>+ if ((-f "COPYING") && (-f "CREDITS") && (-f "Kbuild") &&
>+ (-f "MAINTAINERS") && (-f "Makefile") && (-f "README")
> diff --git a/scripts/patch-trivia-detector.pl
> b/scripts/patch-trivia-detector.pl
> new file mode 100755
> index 000..e71c4ef
> --- /dev/null
> +++ b/scripts/patch-trivia-detector.pl
Could we please name this checkpatch.pl to follow naming style in scripts/
The namespace check* and clean*
On Sun, 27 May 2007 18:11:25 +0100 Andy Whitcroft <[EMAIL PROTECTED]> wrote:
> +#gotos aren't indented
> + if($line=~/^\s*[A-Za-z\d_]+:/ and !($line=~/^\s*default:/)){
> + print "Gotos should not be indented\n";
> + print "$herecurr";
> +
On Sun, May 27, 2007 at 06:11:25PM +0100, Andy Whitcroft wrote:
> +# (c) 2001, Dave Jones. <[EMAIL PROTECTED]> (the file handling bit)
dead email address.
Dave
--
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a mes
Andy Whitcroft <[EMAIL PROTECTED]> writes:
> @@ -223,7 +236,7 @@ pref("mailnews.display.disable_format_flowed_support",
> true);
>
>
>
> -7) E-mail size.
> +8) E-mail size.
>
> When sending patches to Linus, always follow step #6.
That's step #7 now.
Andreas.
--
Andreas Schwab, SuSE
On Sun, 27 May 2007 18:11:25 +0100 Andy Whitcroft wrote:
> Also if either Joel or Randy want to be on on the MAINTAINERS
> entry yell and we'll get it updated, wouldn't want to list
> anyone without permission.
Yes, please.
> I have the infrastructure in place to for the
36 matches
Mail list logo
