Re: [PATCH] USB Elan FTDI: check for workqueue creation v2

2007-02-24 Thread Pete Zaitcev
On Sat, 24 Feb 2007 10:41:15 +0300, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: > Thanks a lot for comments and Ack the patch please. Cyrill, I forgot to mention a couple of points, sorry. > printk(KERN_INFO "driver %s built at %s on %s\n", > ftdi_elan_driver.name, > - _

Re: [PATCH] USB Elan FTDI: check for workqueue creation v2

2007-02-24 Thread Cyrill Gorcunov
On Sat, Feb 24, 2007 at 01:46:44PM +0100, Oleg Verych wrote: | > From: Cyrill Gorcunov | > Newsgroups: gmane.linux.kernel | > Subject: bss zeroing ([PATCH] USB Elan FTDI: check for workqueue creation v2) | > Date: Sat, 24 Feb 2007 10:41:15 +0300 | [] | > Btw, Pete, you are right! C99 ANSI standart

Re: [PATCH] USB Elan FTDI: check for workqueue creation v2

2007-02-24 Thread Oleg Verych
> From: Cyrill Gorcunov > Newsgroups: gmane.linux.kernel > Subject: bss zeroing ([PATCH] USB Elan FTDI: check for workqueue creation v2) > Date: Sat, 24 Feb 2007 10:41:15 +0300 [] > Btw, Pete, you are right! C99 ANSI standart says that static pointer > if it not initialized explicitly has to be set

Re: [PATCH] USB Elan FTDI: check for workqueue creation

2007-02-23 Thread Cyrill Gorcunov
On Fri, Feb 23, 2007 at 05:43:37PM -0800, Pete Zaitcev wrote: | On Fri, 23 Feb 2007 11:10:05 +0300, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: | | > I may be wrong, but a lot of the kernel code have static pointers | > initialized to NULL with explicit manner... More over I always thought | > that

Re: [PATCH] USB Elan FTDI: check for workqueue creation

2007-02-23 Thread Pete Zaitcev
On Fri, 23 Feb 2007 11:10:05 +0300, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: > I may be wrong, but a lot of the kernel code have static pointers > initialized to NULL with explicit manner... More over I always thought > that _static_ is not mean _initialized to zero_. I think _static_ is > just

Re: [PATCH] USB Elan FTDI: check for workqueue creation

2007-02-23 Thread Cyrill Gorcunov
On Thu, Feb 22, 2007 at 11:57:38PM -0800, Pete Zaitcev wrote: | On Fri, 23 Feb 2007 10:53:22 +0300, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: | | > | > -static struct workqueue_struct *status_queue; | > | > +static struct workqueue_struct *status_queue = NULL; | | > | You better drop this part.

Re: [PATCH] USB Elan FTDI: check for workqueue creation

2007-02-22 Thread Cyrill Gorcunov
On Thu, Feb 22, 2007 at 03:55:23PM -0800, Pete Zaitcev wrote: | On Mon, 19 Feb 2007 21:15:49 +0300, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: | | > +++ b/drivers/usb/misc/ftdi-elan.c | > @@ -57,9 +57,9 @@ module_param(distrust_firmware, bool, 0); | > MODULE_PARM_DESC(distrust_firmware, "true to

Re: [PATCH] USB Elan FTDI: check for workqueue creation

2007-02-22 Thread Pete Zaitcev
On Mon, 19 Feb 2007 21:15:49 +0300, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: > +++ b/drivers/usb/misc/ftdi-elan.c > @@ -57,9 +57,9 @@ module_param(distrust_firmware, bool, 0); > MODULE_PARM_DESC(distrust_firmware, "true to distrust firmware > power/overcurren" > "t setup"); > extern