Re: [PATCH] USB: move usb debugfs directory creation to the usb common core

2019-06-05 Thread Greg Kroah-Hartman
On Wed, Jun 05, 2019 at 03:50:31PM +0800, Chunfeng Yun wrote: > On Tue, 2019-06-04 at 13:59 +0200, Greg Kroah-Hartman wrote: > > On Tue, Jun 04, 2019 at 11:32:58AM +0200, Greg Kroah-Hartman wrote: > > > The USB gadget subsystem wants to use the USB debugfs root directory, so > > > move it to the co

Re: [PATCH] USB: move usb debugfs directory creation to the usb common core

2019-06-05 Thread Chunfeng Yun
On Wed, 2019-06-05 at 10:28 +0300, Felipe Balbi wrote: > Hi, > > Greg Kroah-Hartman writes: > >> Greg Kroah-Hartman writes: > >> > diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c > >> > index 7fcb9f782931..f3d6b1ab80cb 100644 > >> > --- a/drivers/usb/core/usb.c > >> > +++ b/drivers/

Re: [PATCH] USB: move usb debugfs directory creation to the usb common core

2019-06-05 Thread Chunfeng Yun
On Tue, 2019-06-04 at 13:59 +0200, Greg Kroah-Hartman wrote: > On Tue, Jun 04, 2019 at 11:32:58AM +0200, Greg Kroah-Hartman wrote: > > The USB gadget subsystem wants to use the USB debugfs root directory, so > > move it to the common "core" USB code so that it is properly initialized > > and remove

Re: [PATCH] USB: move usb debugfs directory creation to the usb common core

2019-06-05 Thread Felipe Balbi
Hi, Greg Kroah-Hartman writes: >> Greg Kroah-Hartman writes: >> > diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c >> > index 7fcb9f782931..f3d6b1ab80cb 100644 >> > --- a/drivers/usb/core/usb.c >> > +++ b/drivers/usb/core/usb.c >> > @@ -1185,19 +1185,17 @@ static struct notifier_blo

Re: [PATCH] USB: move usb debugfs directory creation to the usb common core

2019-06-05 Thread kbuild test robot
Hi Greg, I love your patch! Yet something to improve: [auto build test ERROR on usb/usb-testing] [also build test ERROR on v5.2-rc3 next-20190604] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH] USB: move usb debugfs directory creation to the usb common core

2019-06-04 Thread Chunfeng Yun
On Tue, 2019-06-04 at 13:59 +0200, Greg Kroah-Hartman wrote: > On Tue, Jun 04, 2019 at 11:32:58AM +0200, Greg Kroah-Hartman wrote: > > The USB gadget subsystem wants to use the USB debugfs root directory, so > > move it to the common "core" USB code so that it is properly initialized > > and remove

Re: [PATCH] USB: move usb debugfs directory creation to the usb common core

2019-06-04 Thread Greg Kroah-Hartman
On Tue, Jun 04, 2019 at 03:25:14PM +0300, Felipe Balbi wrote: > > Hi, > > Greg Kroah-Hartman writes: > > diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c > > index 7fcb9f782931..f3d6b1ab80cb 100644 > > --- a/drivers/usb/core/usb.c > > +++ b/drivers/usb/core/usb.c > > @@ -1185,19 +118

Re: [PATCH] USB: move usb debugfs directory creation to the usb common core

2019-06-04 Thread Felipe Balbi
Hi, Greg Kroah-Hartman writes: > diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c > index 7fcb9f782931..f3d6b1ab80cb 100644 > --- a/drivers/usb/core/usb.c > +++ b/drivers/usb/core/usb.c > @@ -1185,19 +1185,17 @@ static struct notifier_block usb_bus_nb = { > .notifier_call = us

Re: [PATCH] USB: move usb debugfs directory creation to the usb common core

2019-06-04 Thread Greg Kroah-Hartman
On Tue, Jun 04, 2019 at 11:32:58AM +0200, Greg Kroah-Hartman wrote: > The USB gadget subsystem wants to use the USB debugfs root directory, so > move it to the common "core" USB code so that it is properly initialized > and removed as needed. > > Signed-off-by: Greg Kroah-Hartman > > --- > > Th