Re: [PATCH] UBI: vtbl: Use ubi_eba_atomic_leb_change()

2014-10-31 Thread Richard Weinberger
Am 31.10.2014 um 11:45 schrieb hujianyang: > This question is basing on your comment for this patch: > > """ > we can guarantee that the first VTBL record is always > correct and we don't really need the second one anymore. > """ > > I think that means one PEB is enough in your considering. > So

Re: [PATCH] UBI: vtbl: Use ubi_eba_atomic_leb_change()

2014-10-31 Thread hujianyang
On 2014/10/31 16:09, Richard Weinberger wrote: > Hujianyang, > > Am 31.10.2014 um 05:03 schrieb hujianyang: >> Hi Artem and Richard, >> >> We are using atomic operation, leb_change(), for master_node >> in ubifs-level. We use two lebs for master_node even if they >> are changed with atomic operati

Re: [PATCH] UBI: vtbl: Use ubi_eba_atomic_leb_change()

2014-10-31 Thread Richard Weinberger
Hujianyang, Am 31.10.2014 um 05:03 schrieb hujianyang: > Hi Artem and Richard, > > We are using atomic operation, leb_change(), for master_node > in ubifs-level. We use two lebs for master_node even if they > are changed with atomic operation. > > I think volume_table and master_node play simila

Re: [PATCH] UBI: vtbl: Use ubi_eba_atomic_leb_change()

2014-10-30 Thread hujianyang
On 2014/10/30 16:55, Artem Bityutskiy wrote: > On Sat, 2014-10-25 at 19:43 +0200, Richard Weinberger wrote: >> This is more a cosmetic change than a fix. >> By using ubi_eba_atomic_leb_change() >> we can guarantee that the first VTBL record is always >> correct and we don't really need the second o

Re: [PATCH] UBI: vtbl: Use ubi_eba_atomic_leb_change()

2014-10-30 Thread Artem Bityutskiy
On Sat, 2014-10-25 at 19:43 +0200, Richard Weinberger wrote: > This is more a cosmetic change than a fix. > By using ubi_eba_atomic_leb_change() > we can guarantee that the first VTBL record is always > correct and we don't really need the second one anymore. > But we have to keep the second one to