Re: [PATCH] To add NULL pointer check

2013-04-03 Thread P J P
+-- On Thu, 4 Apr 2013, Jaegeuk Kim wrote --+ | Why should we take unnecessary locks and an f2fs_submit_bio call? Yep, we should not. I wasn't sure if these are unnecessary when a_ops->writepage = NULL. Thank you. -- Prasad J Pandit / Red Hat Security Response Team DB7A 84C5 D3F9 7CD1 B5EB C9

Re: [PATCH] To add NULL pointer check

2013-04-03 Thread Jaegeuk Kim
Hi, 2013-04-03 (수), 14:43 +0530, P J P: > +-- On Wed, 3 Apr 2013, Jaegeuk Kim wrote --+ > | I'm confusing the question because f2fs doesn't use generic_writepages(), > | since f2fs_write_data_pages() is linked to a_ops->writepages. In > | do_writepages(), always f2fs_write_data_pages() is trigge

Re: [PATCH] To add NULL pointer check

2013-04-03 Thread P J P
+-- On Wed, 3 Apr 2013, Jaegeuk Kim wrote --+ | I'm confusing the question because f2fs doesn't use generic_writepages(), | since f2fs_write_data_pages() is linked to a_ops->writepages. In | do_writepages(), always f2fs_write_data_pages() is triggered instead of | generic_writepages(). Isn't it?

Re: [PATCH] To add NULL pointer check

2013-04-03 Thread Jaegeuk Kim
Hi, 2013-04-03 (수), 12:30 +0530, P J P: > +-- On Wed, 3 Apr 2013, Jaegeuk Kim wrote --+ > | diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > | index 47a2d7c..cf9ff5f 100644 > | --- a/fs/f2fs/data.c > | +++ b/fs/f2fs/data.c > | @@ -559,6 +559,10 @@ static int f2fs_write_data_pages(struct > | address_

Re: [PATCH] To add NULL pointer check

2013-04-03 Thread P J P
+-- On Wed, 3 Apr 2013, Jaegeuk Kim wrote --+ | diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c | index 47a2d7c..cf9ff5f 100644 | --- a/fs/f2fs/data.c | +++ b/fs/f2fs/data.c | @@ -559,6 +559,10 @@ static int f2fs_write_data_pages(struct | address_space *mapping, | int ret; | long excess_nr

Re: [PATCH] To add NULL pointer check

2013-04-02 Thread P J P
Hello Jaegeuk, +-- On Wed, 3 Apr 2013, Jaegeuk Kim wrote --+ | Therefore, I think f2fs_write_data_pages() is better to handle this. Please | review the modified patch. Thanks, | | diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c | index 47a2d7c..cf9ff5f 100644 | --- a/fs/f2fs/data.c | +++ b/fs/f2fs

Re: [PATCH] To add NULL pointer check

2013-04-02 Thread Namjae Jeon
2013/4/3, Jaegeuk Kim : > Hi, > Thank you for your contribution. > > As I consider the null pointer check, generic_writepages() originally > does so. > Therefore, I think f2fs_write_data_pages() is better to handle this. > Please review the modified patch. > Thanks, > > --- > From d3c811a51c7062fb1

Re: [PATCH] To add NULL pointer check

2013-04-02 Thread Jaegeuk Kim
Hi, Thank you for your contribution. As I consider the null pointer check, generic_writepages() originally does so. Therefore, I think f2fs_write_data_pages() is better to handle this. Please review the modified patch. Thanks, --- From d3c811a51c7062fb1b66bec910ed346447c02032 Mon Sep 17 00:00:00