Re: [PATCH] Stop docproc segfaulting when SRCTREE isn't set.

2007-10-18 Thread Sam Ravnborg
On Tue, Oct 09, 2007 at 01:25:18AM -0500, Rob Landley wrote: > From: Rob Landley <[EMAIL PROTECTED]> > > Prevent docproc from segfaulting when SRCTREE isn't set. > > Signed-off-by: Rob Landley <[EMAIL PROTECTED]> Applied to kbuild.git (with Randy's style fixup). Sam - To unsubscribe fro

Re: [PATCH] Stop docproc segfaulting when SRCTREE isn't set.

2007-10-09 Thread Rob Landley
On Tuesday 09 October 2007 8:03:15 am Ahmed S. Darwish wrote: > $ man getcwd > > char *getcwd(char *buf, size_t size); > > As an extension to the POSIX.1 standard, Linux (libc4, libc5, glibc) > getcwd() allocates the buffer dynamically using malloc() if buf is NULL on > call. > > Shouldn't "srctr

Re: [PATCH] Stop docproc segfaulting when SRCTREE isn't set.

2007-10-09 Thread Ahmed S. Darwish
On Tue, Oct 09, 2007 at 10:24:03AM -0700, Randy Dunlap wrote: > Ahmed S. Darwish wrote: > >On Tue, Oct 09, 2007 at 08:55:00AM -0700, Randy Dunlap wrote: > >>On Tue, 9 Oct 2007 15:03:15 +0200 Ahmed S. Darwish wrote: > >> > >>>Hi Rob, > >>> > >>>On Tue, Oct 09, 2007 at 01:25:18AM -0500, Rob Landley w

Re: [PATCH] Stop docproc segfaulting when SRCTREE isn't set.

2007-10-09 Thread Randy Dunlap
Ahmed S. Darwish wrote: On Tue, Oct 09, 2007 at 08:55:00AM -0700, Randy Dunlap wrote: On Tue, 9 Oct 2007 15:03:15 +0200 Ahmed S. Darwish wrote: Hi Rob, On Tue, Oct 09, 2007 at 01:25:18AM -0500, Rob Landley wrote: [...] FILE * infile; + + srctree = getenv("SRCTREE"); + if

Re: [PATCH] Stop docproc segfaulting when SRCTREE isn't set.

2007-10-09 Thread Ahmed S. Darwish
On Tue, Oct 09, 2007 at 08:55:00AM -0700, Randy Dunlap wrote: > On Tue, 9 Oct 2007 15:03:15 +0200 Ahmed S. Darwish wrote: > > > Hi Rob, > > > > On Tue, Oct 09, 2007 at 01:25:18AM -0500, Rob Landley wrote: > > [...] > > > FILE * infile; > > > + > > > + srctree = getenv("SRCTREE"); > > > + if (!s

Re: [PATCH] Stop docproc segfaulting when SRCTREE isn't set.

2007-10-09 Thread Randy Dunlap
On Tue, 9 Oct 2007 01:25:18 -0500 Rob Landley wrote: > From: Rob Landley <[EMAIL PROTECTED]> > > Prevent docproc from segfaulting when SRCTREE isn't set. > > Signed-off-by: Rob Landley <[EMAIL PROTECTED]> Acked-by: Randy Dunlap <[EMAIL PROTECTED]> but needs 2 coding style fixes... see near end

Re: [PATCH] Stop docproc segfaulting when SRCTREE isn't set.

2007-10-09 Thread Randy Dunlap
On Tue, 9 Oct 2007 15:03:15 +0200 Ahmed S. Darwish wrote: > Hi Rob, > > On Tue, Oct 09, 2007 at 01:25:18AM -0500, Rob Landley wrote: > [...] > > FILE * infile; > > + > > + srctree = getenv("SRCTREE"); > > + if (!srctree) srctree = getcwd(NULL,0); > > if (argc != 3) { > > u

Re: [PATCH] Stop docproc segfaulting when SRCTREE isn't set.

2007-10-09 Thread Ahmed S. Darwish
Hi Rob, On Tue, Oct 09, 2007 at 01:25:18AM -0500, Rob Landley wrote: [...] > FILE * infile; > + > + srctree = getenv("SRCTREE"); > + if (!srctree) srctree = getcwd(NULL,0); > if (argc != 3) { > usage(); > exit(1); $ man getcwd char *getcwd(char *b