Re: [PATCH] RISC-V: Fix FIXMAP area corruption on RV32 systems

2019-08-26 Thread Alistair Francis
On Mon, 2019-08-26 at 14:17 -0700, Palmer Dabbelt wrote: > On Sun, 18 Aug 2019 21:49:01 PDT (-0700), a...@brainfault.org wrote: > > On Sun, Aug 18, 2019 at 11:49 PM Christoph Hellwig < > > h...@infradead.org> wrote: > > > > +#define FIXADDR_TOP (VMALLOC_START) > > > > > > Nit: no need for the

Re: [PATCH] RISC-V: Fix FIXMAP area corruption on RV32 systems

2019-08-26 Thread Palmer Dabbelt
On Sun, 18 Aug 2019 21:49:01 PDT (-0700), a...@brainfault.org wrote: On Sun, Aug 18, 2019 at 11:49 PM Christoph Hellwig wrote: > +#define FIXADDR_TOP (VMALLOC_START) Nit: no need for the braces, the definitions below don't use it either. Sure, I will update and send v2 soon. > +#ifd

Re: [PATCH] RISC-V: Fix FIXMAP area corruption on RV32 systems

2019-08-18 Thread Anup Patel
On Sun, Aug 18, 2019 at 11:49 PM Christoph Hellwig wrote: > > > +#define FIXADDR_TOP (VMALLOC_START) > > Nit: no need for the braces, the definitions below don't use it > either. Sure, I will update and send v2 soon. > > > +#ifdef CONFIG_64BIT > > +#define FIXADDR_SIZE PMD_SIZE > > +#el

Re: [PATCH] RISC-V: Fix FIXMAP area corruption on RV32 systems

2019-08-18 Thread Christoph Hellwig
> +#define FIXADDR_TOP (VMALLOC_START) Nit: no need for the braces, the definitions below don't use it either. > +#ifdef CONFIG_64BIT > +#define FIXADDR_SIZE PMD_SIZE > +#else > +#define FIXADDR_SIZE PGDIR_SIZE > +#endif > +#define FIXADDR_START(FIXADDR_TOP - FIXADDR_SIZE) > + >

Re: [PATCH] RISC-V: Fix FIXMAP area corruption on RV32 systems

2019-08-16 Thread Alistair Francis
On Fri, 2019-08-16 at 11:49 +, Anup Patel wrote: > Currently, the order of various virtual memory areas in increasing > order of virtual addresses is as follows: > 1. User space area > 2. FIXMAP area > 3. VMALLOC area > 4. Kernel area > > The user space area starts at 0x0 and it's maximum size