Re: [PATCH] RDMA/rvt: Improve exception handling in rvt_create_qp()

2020-06-14 Thread Markus Elfring
> … >> +++ b/drivers/infiniband/sw/rdmavt/qp.c >> @@ -1203,6 +1203,7 @@ struct ib_qp *rvt_create_qp(struct ib_pd *ibpd, >> qp->s_flags = RVT_S_SIGNAL_REQ_WR; >> err = alloc_ud_wq_attr(qp, rdi->dparms.node); >> if (err) { >> +rvt_fr

Re: [PATCH] RDMA/rvt: Improve exception handling in rvt_create_qp()

2020-06-14 Thread Greg KH
On Sat, Jun 13, 2020 at 09:15:12AM +0200, Markus Elfring wrote: > > … The patch fixes this issue by > > calling rvt_free_rq(). > > I suggest to choose another imperative wording for your change description. > Will the tag “Fixes” become helpful for the commit message? > > … > > +++ b/drivers/infi

Re: [PATCH] RDMA/rvt: Improve exception handling in rvt_create_qp()

2020-06-13 Thread Markus Elfring
> … The patch fixes this issue by > calling rvt_free_rq(). I suggest to choose another imperative wording for your change description. Will the tag “Fixes” become helpful for the commit message? … > +++ b/drivers/infiniband/sw/rdmavt/qp.c > @@ -1203,6 +1203,7 @@ struct ib_qp *rvt_create_qp(struc