Re: [PATCH] Permissions don't stick on ConfigFS attributes

2005-08-22 Thread Eric W. Biederman
I am confused. I am beginning to see shades of the devfs problems coming up again. sysfs is built to be world readable by everyone who has it mounted in their namespace. Writable files in sysfs I have never understood. Given that we now have files which do not conform to one uniform policy for

Re: [PATCH] Permissions don't stick on ConfigFS attributes

2005-08-22 Thread Daniel Phillips
On Monday 22 August 2005 00:49, Eric W. Biederman wrote: > I am confused. I am beginning to see shades of the devfs problems coming > up again. sysfs is built to be world readable by everyone who has it > mounted in their namespace. Writable files in sysfs I have never > understood. Sysfs is no

Re: [PATCH] Permissions don't stick on ConfigFS attributes

2005-08-20 Thread Daniel Phillips
On Saturday 20 August 2005 16:31, Joel Becker wrote: > On Fri, Aug 19, 2005 at 08:01:17PM -0700, Greg KH wrote: > > The recent changes to sysfs should be ported to configfs to do this. > > Yeah, I've been meaning to do something, and resusing code is > always a good plan. Ending up with the

Re: [PATCH] Permissions don't stick on ConfigFS attributes

2005-08-19 Thread Joel Becker
On Fri, Aug 19, 2005 at 08:01:17PM -0700, Greg KH wrote: > The recent changes to sysfs should be ported to configfs to do this. Yeah, I've been meaning to do something, and resusing code is always a good plan. Hopefully I can get to this soon. Joel -- "I don't know anything about mus

Re: [PATCH] Permissions don't stick on ConfigFS attributes

2005-08-19 Thread Daniel Phillips
On Saturday 20 August 2005 11:22, Jon Smirl wrote: > A patch for making sysfs attributes persistent has recently made it > into Linus' tree. > > http://article.gmane.org/gmane.linux.hotplug.devel/7927/match=sysfs+permissions Interesting, it handles more than just the file mode. But does anybody

Re: [PATCH] Permissions don't stick on ConfigFS attributes

2005-08-19 Thread Daniel Phillips
On Saturday 20 August 2005 13:33, Greg KH wrote: > On Sat, Aug 20, 2005 at 01:23:29PM +1000, Daniel Phillips wrote: > > On Saturday 20 August 2005 13:01, Greg KH wrote: > > > On Sat, Aug 20, 2005 at 10:50:51AM +1000, Daniel Phillips wrote: > > > > So: Integrate with sysfs. > > > > > > No, don't. D

Re: [PATCH] Permissions don't stick on ConfigFS attributes

2005-08-19 Thread Greg KH
On Sat, Aug 20, 2005 at 01:23:29PM +1000, Daniel Phillips wrote: > On Saturday 20 August 2005 13:01, Greg KH wrote: > > On Sat, Aug 20, 2005 at 10:50:51AM +1000, Daniel Phillips wrote: > > > So: Integrate with sysfs. > > > > No, don't. Do you think that Joel would not have already worked with > >

Re: [PATCH] Permissions don't stick on ConfigFS attributes

2005-08-19 Thread Daniel Phillips
On Saturday 20 August 2005 13:01, Greg KH wrote: > On Sat, Aug 20, 2005 at 10:50:51AM +1000, Daniel Phillips wrote: > > So: Integrate with sysfs. > > No, don't. Do you think that Joel would not have already worked with > the sysfs people prior to submitting this? No, he did, and we all > agreed t

Re: [PATCH] Permissions don't stick on ConfigFS attributes

2005-08-19 Thread Greg KH
On Sat, Aug 20, 2005 at 10:50:51AM +1000, Daniel Phillips wrote: > Hi Joel, > > Permissions set on ConfigFS attributes (aka files) do not stick. The recent changes to sysfs should be ported to configfs to do this. > So: Integrate with sysfs. No, don't. Do you think that Joel would not have alr

Re: [PATCH] Permissions don't stick on ConfigFS attributes

2005-08-19 Thread Jon Smirl
On 8/19/05, Daniel Phillips <[EMAIL PROTECTED]> wrote: > Hi Joel, > > Permissions set on ConfigFS attributes (aka files) do not stick. The reason > is that configfs attribute inodes are not pinned and simply disappear after > each file operation. This is good because it saves memory, but it is n