Re: [PATCH] Pageset Localization V2

2005-03-30 Thread Christoph Lameter
Patch to fix the issues mentioned so far. The MAKE_LIST macro would also not be good to some things that I have planned so lets drop it. Index: linux-2.6.11/mm/page_alloc.c === --- linux-2.6.11.orig/mm/page_alloc.c 2005-03-30 19:45:

Re: [PATCH] Pageset Localization V2

2005-03-30 Thread Matthew Wilcox
On Tue, Mar 29, 2005 at 09:51:08PM -0800, Christoph Lameter wrote: > + BUG_ON(process_zones(smp_processor_id())); No. Who told you this was a good idea? This is the *worst* kind of assert, calling a function with side-effects. -- "Next the statesmen will invent cheap lies, putting the blam

Re: [PATCH] Pageset Localization V2

2005-03-30 Thread Christoph Hellwig
> +#define MAKE_LIST(list, nlist) \ > + do {\ > + if(list_empty(&list)) \ > + INIT_LIST_HEAD(nlist); \ > + else { nlist->next->prev = nlist; \ > + nlist->prev->next = nlist; \ > + }