Re: [PATCH] PCI: keystone: update to support multiple pci ports

2014-09-09 Thread Arnd Bergmann
On Monday 08 September 2014 11:52:47 Murali Karicheri wrote: > On 09/05/2014 05:11 PM, Arnd Bergmann wrote: > > But the driver can only do root complex mode, and we would probably > > want a completely different driver if we were to start supporting > > endpoint mode. > > Good point! I will drop i

Re: [PATCH] PCI: keystone: update to support multiple pci ports

2014-09-08 Thread Murali Karicheri
On 09/05/2014 05:11 PM, Arnd Bergmann wrote: On Friday 05 September 2014 16:37:25 Murali Karicheri wrote: On 09/05/2014 03:00 PM, Arnd Bergmann wrote: On Friday 05 September 2014 14:33:54 Murali Karicheri wrote: This looks like it's a shared register of some sort that doesn't really belong int

Re: [PATCH] PCI: keystone: update to support multiple pci ports

2014-09-05 Thread Arnd Bergmann
On Friday 05 September 2014 16:37:25 Murali Karicheri wrote: > On 09/05/2014 03:00 PM, Arnd Bergmann wrote: > > On Friday 05 September 2014 14:33:54 Murali Karicheri wrote: > >>> This looks like it's a shared register of some sort that doesn't > >>> really belong into the registers of a particular

Re: [PATCH] PCI: keystone: update to support multiple pci ports

2014-09-05 Thread Murali Karicheri
On 09/05/2014 03:00 PM, Arnd Bergmann wrote: On Friday 05 September 2014 14:33:54 Murali Karicheri wrote: This looks like it's a shared register of some sort that doesn't really belong into the registers of a particular port. Could it be that it's actually for the PHY? This a shared device con

Re: [PATCH] PCI: keystone: update to support multiple pci ports

2014-09-05 Thread Arnd Bergmann
On Friday 05 September 2014 14:33:54 Murali Karicheri wrote: > > This looks like it's a shared register of some sort that doesn't > > really belong into the registers of a particular port. Could it > > be that it's actually for the PHY? > > > This a shared device configuration register between the

Re: [PATCH] PCI: keystone: update to support multiple pci ports

2014-09-05 Thread Murali Karicheri
On 09/05/2014 01:54 PM, Arnd Bergmann wrote: On Friday 05 September 2014 13:39:42 Murali Karicheri wrote: + /* enable RC mode in devcfg */ val = readl(reg_p); - val&= ~PCIE_MODE_MASK; - val |= PCIE_RC_MODE; + port_id<<= 1; + val&= ~(PCIE_MODE_MASK<< por

Re: [PATCH] PCI: keystone: update to support multiple pci ports

2014-09-05 Thread Arnd Bergmann
On Friday 05 September 2014 13:39:42 Murali Karicheri wrote: > + > /* enable RC mode in devcfg */ > val = readl(reg_p); > - val &= ~PCIE_MODE_MASK; > - val |= PCIE_RC_MODE; > + port_id <<= 1; > + val &= ~(PCIE_MODE_MASK << port_id); > + val |= (PCIE_RC_