Re: [PATCH] PCI: Do not touch siblings in pci_assign_unassigned_bridge_resources

2014-07-01 Thread Yinghai Lu
On Mon, Jun 30, 2014 at 3:47 PM, Bjorn Helgaas wrote: >> Should not be dangerous, just second try. > > I still don't understand this. Why do we set "res->flags = 0"? That > clears out the resource type. Where do we figure out the type of "res" > again? pci_bridge_check_ranges() >> Subject: [P

Re: [PATCH] PCI: Do not touch siblings in pci_assign_unassigned_bridge_resources

2014-06-30 Thread Bjorn Helgaas
On Wed, Jun 18, 2014 at 09:41:02PM -0700, Yinghai Lu wrote: > On Wed, Jun 18, 2014 at 3:40 PM, Andreas Noever > wrote: > > On Wed, Jun 18, 2014 at 1:39 AM, Yinghai Lu wrote: > > It seems to fix the testcase (no unwanted resources are released). But > > why do you reassign bus and not just skip th

Re: [PATCH] PCI: Do not touch siblings in pci_assign_unassigned_bridge_resources

2014-06-18 Thread Yinghai Lu
On Wed, Jun 18, 2014 at 3:40 PM, Andreas Noever wrote: > On Wed, Jun 18, 2014 at 1:39 AM, Yinghai Lu wrote: > It seems to fix the testcase (no unwanted resources are released). But > why do you reassign bus and not just skip the top level bridge? If one > of the allocations below bridge failed th

Re: [PATCH] PCI: Do not touch siblings in pci_assign_unassigned_bridge_resources

2014-06-18 Thread Andreas Noever
On Wed, Jun 18, 2014 at 1:39 AM, Yinghai Lu wrote: > On Tue, Jun 17, 2014 at 3:16 PM, Bjorn Helgaas wrote: >> [+cc Yinghai] >> >> On Mon, Jun 09, 2014 at 10:45:30PM +0200, Andreas Noever wrote: >>> The problem can be reproduced by having two sibling hotplug bridges A >>> and B. The problem will o

Re: [PATCH] PCI: Do not touch siblings in pci_assign_unassigned_bridge_resources

2014-06-17 Thread Yinghai Lu
On Tue, Jun 17, 2014 at 3:16 PM, Bjorn Helgaas wrote: > [+cc Yinghai] > > On Mon, Jun 09, 2014 at 10:45:30PM +0200, Andreas Noever wrote: >> The problem can be reproduced by having two sibling hotplug bridges A >> and B. The problem will occour if the parent of A and B does not have >> enough reso

Re: [PATCH] PCI: Do not touch siblings in pci_assign_unassigned_bridge_resources

2014-06-17 Thread Bjorn Helgaas
[+cc Yinghai] On Mon, Jun 09, 2014 at 10:45:30PM +0200, Andreas Noever wrote: > pci_assign_unassigned_bridge_resources is used to assign resources below > a hotplug bridge. If the first attempt fails it will release some > resources and try again. If a resource allocation on the hotplug bridge > i