Re: [PATCH] PCI: Add link_change error handler and vfio-pci user

2019-04-30 Thread Keith Busch
On Mon, Apr 29, 2019 at 10:59:26AM -0600, Alex Williamson wrote: > On Mon, 29 Apr 2019 09:45:28 -0700 > Sinan Kaya wrote: > > > On 4/29/2019 10:51 AM, Alex Williamson wrote: > > > So where do we go from here? I agree that dmesg is not necessarily a > > > great choice for these sorts of events an

Re: [PATCH] PCI: Add link_change error handler and vfio-pci user

2019-04-29 Thread Bjorn Helgaas
On Mon, Apr 29, 2019 at 08:51:04AM -0600, Alex Williamson wrote: > On Wed, 24 Apr 2019 12:57:58 -0500 > Bjorn Helgaas wrote: > > > On Tue, Apr 23, 2019 at 04:42:28PM -0600, Alex Williamson wrote: > > > The PCIe bandwidth notification service generates logging any time a > > > link changes speed o

Re: [PATCH] PCI: Add link_change error handler and vfio-pci user

2019-04-29 Thread Alex Williamson
On Mon, 29 Apr 2019 09:45:28 -0700 Sinan Kaya wrote: > On 4/29/2019 10:51 AM, Alex Williamson wrote: > > So where do we go from here? I agree that dmesg is not necessarily a > > great choice for these sorts of events and if they went somewhere else, > > maybe I wouldn't have the same concerns ab

Re: [PATCH] PCI: Add link_change error handler and vfio-pci user

2019-04-29 Thread Sinan Kaya
On 4/29/2019 10:51 AM, Alex Williamson wrote: So where do we go from here? I agree that dmesg is not necessarily a great choice for these sorts of events and if they went somewhere else, maybe I wouldn't have the same concerns about them generating user confusion or contributing to DoS vectors f

Re: [PATCH] PCI: Add link_change error handler and vfio-pci user

2019-04-29 Thread Alex Williamson
On Wed, 24 Apr 2019 12:57:58 -0500 Bjorn Helgaas wrote: > On Tue, Apr 23, 2019 at 04:42:28PM -0600, Alex Williamson wrote: > > The PCIe bandwidth notification service generates logging any time a > > link changes speed or width to a state that is considered downgraded. > > Unfortunately, it canno

Re: [PATCH] PCI: Add link_change error handler and vfio-pci user

2019-04-24 Thread Alex_Gagniuc
On 4/23/2019 5:42 PM, Alex Williamson wrote: > The PCIe bandwidth notification service generates logging any time a > link changes speed or width to a state that is considered downgraded. > Unfortunately, it cannot differentiate signal integrity related link > changes from those intentionally initi

Re: [PATCH] PCI: Add link_change error handler and vfio-pci user

2019-04-24 Thread Alex Williamson
On Wed, 24 Apr 2019 16:45:45 + wrote: > On 4/23/2019 5:42 PM, Alex Williamson wrote: > > The PCIe bandwidth notification service generates logging any time a > > link changes speed or width to a state that is considered downgraded. > > Unfortunately, it cannot differentiate signal integrity r

Re: [PATCH] PCI: Add link_change error handler and vfio-pci user

2019-04-24 Thread Bjorn Helgaas
On Tue, Apr 23, 2019 at 04:42:28PM -0600, Alex Williamson wrote: > The PCIe bandwidth notification service generates logging any time a > link changes speed or width to a state that is considered downgraded. > Unfortunately, it cannot differentiate signal integrity related link > changes from those

Re: [PATCH] PCI: Add link_change error handler and vfio-pci user

2019-04-24 Thread Alex G
On 4/24/19 12:19 PM, Alex Williamson wrote: On Wed, 24 Apr 2019 16:45:45 + wrote: On 4/23/2019 5:42 PM, Alex Williamson wrote: diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 7e12d0163863..233cd4b5b6e8 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -2403,6 +2403