Re: [PATCH] PCI/MSI: Improve MSI alias detection

2017-07-31 Thread Bjorn Helgaas
Hi Robin, Can you post a new patch with the updates below, e.g., the fact that MSI writes don't use phantom RIDs, the set_msi_sid() reference, a comment about why it's safe for get_msi_id_cb() to ignore all but the last alias, etc? These are subtle things that other readers will likely wonder abo

Re: [PATCH] PCI/MSI: Improve MSI alias detection

2017-06-20 Thread Robin Murphy
On 19/06/17 22:52, Bjorn Helgaas wrote: > [+cc David, Alex] > > On Wed, May 31, 2017 at 06:52:28PM +0100, Robin Murphy wrote: >> Currently, we consider all DMA aliases when calculating MSI requester >> IDs. This turns out to be the wrong thing to do in the face of pure DMA >> quirks like those of

Re: [PATCH] PCI/MSI: Improve MSI alias detection

2017-06-19 Thread Bjorn Helgaas
[+cc David, Alex] On Wed, May 31, 2017 at 06:52:28PM +0100, Robin Murphy wrote: > Currently, we consider all DMA aliases when calculating MSI requester > IDs. This turns out to be the wrong thing to do in the face of pure DMA > quirks like those of Marvell SATA cards, where we can end up configuri