Re: [PATCH] PCI/AER: Do not clear AER bits if we don't own AER

2018-08-09 Thread Alex G.
On 08/09/2018 02:18 PM, Bjorn Helgaas wrote: On Thu, Aug 09, 2018 at 02:00:23PM -0500, Alex G. wrote: On 08/09/2018 01:29 PM, Bjorn Helgaas wrote: On Thu, Aug 09, 2018 at 04:46:32PM +, alex_gagn...@dellteam.com wrote: On 08/09/2018 09:16 AM, Bjorn Helgaas wrote: (snip_ enable_ecr

Re: [PATCH] PCI/AER: Do not clear AER bits if we don't own AER

2018-08-09 Thread Bjorn Helgaas
On Thu, Aug 09, 2018 at 02:00:23PM -0500, Alex G. wrote: > On 08/09/2018 01:29 PM, Bjorn Helgaas wrote: > > On Thu, Aug 09, 2018 at 04:46:32PM +, alex_gagn...@dellteam.com wrote: > > > On 08/09/2018 09:16 AM, Bjorn Helgaas wrote: > (snip_ > > > > enable_ecrc_checking() > > > > disable_e

Re: [PATCH] PCI/AER: Do not clear AER bits if we don't own AER

2018-08-09 Thread Alex G.
On 08/09/2018 01:29 PM, Bjorn Helgaas wrote: On Thu, Aug 09, 2018 at 04:46:32PM +, alex_gagn...@dellteam.com wrote: On 08/09/2018 09:16 AM, Bjorn Helgaas wrote: (snip_ enable_ecrc_checking() disable_ecrc_checking() I don't immediately see how this would affect FFS, but the bit

Re: [PATCH] PCI/AER: Do not clear AER bits if we don't own AER

2018-08-09 Thread Bjorn Helgaas
On Thu, Aug 09, 2018 at 04:46:32PM +, alex_gagn...@dellteam.com wrote: > On 08/09/2018 09:16 AM, Bjorn Helgaas wrote: > > On Tue, Jul 17, 2018 at 10:31:23AM -0500, Alexandru Gagniuc wrote: > >> When we don't own AER, we shouldn't touch the AER error bits. This > >> happens unconditionally on de

Re: [PATCH] PCI/AER: Do not clear AER bits if we don't own AER

2018-08-09 Thread Alex_Gagniuc
On 08/09/2018 09:16 AM, Bjorn Helgaas wrote: > On Tue, Jul 17, 2018 at 10:31:23AM -0500, Alexandru Gagniuc wrote: >> When we don't own AER, we shouldn't touch the AER error bits. This >> happens unconditionally on device probe(). Clearing AER bits >> willy-nilly might cause firmware to miss errors.

Re: [PATCH] PCI/AER: Do not clear AER bits if we don't own AER

2018-08-09 Thread Bjorn Helgaas
On Tue, Jul 17, 2018 at 10:31:23AM -0500, Alexandru Gagniuc wrote: > When we don't own AER, we shouldn't touch the AER error bits. This > happens unconditionally on device probe(). Clearing AER bits > willy-nilly might cause firmware to miss errors. Instead > these bits should get cleared by FFS, o

Re: [PATCH] PCI/AER: Do not clear AER bits if we don't own AER

2018-07-19 Thread Alex G.
On 07/19/2018 11:58 AM, Sinan Kaya wrote: On 7/19/2018 8:55 AM, Alex G. wrote: I find the intent clearer if we check it here rather than having to do the mental parsing of the state of aer_cap. I don't feel too strong about my comment to be honest. This was a style/maintenance comment. It

Re: [PATCH] PCI/AER: Do not clear AER bits if we don't own AER

2018-07-19 Thread Sinan Kaya
On 7/19/2018 8:55 AM, Alex G. wrote: I find the intent clearer if we check it here rather than having to do the mental parsing of the state of aer_cap. I don't feel too strong about my comment to be honest. This was a style/maintenance comment. It feels like we are putting pcie_aer_get_firmw

Re: [PATCH] PCI/AER: Do not clear AER bits if we don't own AER

2018-07-19 Thread Alex G.
On 07/17/2018 10:41 AM, Sinan Kaya wrote: On 7/17/2018 8:31 AM, Alexandru Gagniuc wrote: +    if (pcie_aer_get_firmware_first(dev)) +    return -EIO; Can you move this to closer to the caller pci_aer_init()? I could move it there. although pci_cleanup_aer_error_status_regs() is call

Re: [PATCH] PCI/AER: Do not clear AER bits if we don't own AER

2018-07-17 Thread Sinan Kaya
On 7/17/2018 8:31 AM, Alexandru Gagniuc wrote: + if (pcie_aer_get_firmware_first(dev)) + return -EIO; Can you move this to closer to the caller pci_aer_init()?