[PATCH] Re: [PATCH] NMI watch dog notify patch

2005-08-02 Thread George Anzinger
It seems that the subject patch generates a warning (missed it on the compile). Here is a patch to eliminate the warning. -- George Anzinger george@mvista.com HRT (High-res-timers): http://sourceforge.net/projects/high-res-timers/ Source: MontaVista Software, Inc. George Anzinger Type: Defect

Re: [PATCH] NMI watch dog notify patch

2005-08-01 Thread George Anzinger
Keith Owens wrote: On Fri, 29 Jul 2005 13:55:23 -0700, George Anzinger wrote: This patch adds a notify to the die_nmi notify that the system is about to be taken down. If the notify is handled with a NOTIFY_STOP return, the system is given a new lease on life. void d

Re: [PATCH] NMI watch dog notify patch

2005-07-29 Thread Keith Owens
On Fri, 29 Jul 2005 13:55:23 -0700, George Anzinger wrote: > This patch adds a notify to the die_nmi notify that the system > is about to be taken down. If the notify is handled with a > NOTIFY_STOP return, the system is given a new lease on life. > > void die_nmi (struct pt_r

Re: [PATCH] NMI watch dog notify patch

2005-07-29 Thread George Anzinger
Andrew Morton wrote: Keith Owens <[EMAIL PROTECTED]> wrote: I had though that too, but it does not allow recovery (i.e. lets reset >the watchdog and try again). die_nmi() returns to nmi_watchdog_tick(), nmi_watchdog_tick does the reset and continues. Patch below. >Hmm.. just looked at trap

Re: [PATCH] NMI watch dog notify patch

2005-07-28 Thread Andrew Morton
Keith Owens <[EMAIL PROTECTED]> wrote: > > >I had though that too, but it does not allow recovery (i.e. lets reset > >the watchdog and try again). > > die_nmi() returns to nmi_watchdog_tick(), nmi_watchdog_tick does the > reset and continues. Patch below. > > >Hmm.. just looked at traps.c.

Re: [PATCH] NMI watch dog notify patch

2005-07-28 Thread Keith Owens
On Thu, 28 Jul 2005 21:16:56 -0700, George Anzinger wrote: >Keith Owens wrote: >> On Thu, 28 Jul 2005 13:31:58 -0700, >> George Anzinger wrote: >> >>>I have been doing some work on kgdb to pull a few of it "fingers" out of >>>various places in the kernel. This is the final location where we

Re: [PATCH] NMI watch dog notify patch

2005-07-28 Thread George Anzinger
Keith Owens wrote: On Thu, 28 Jul 2005 13:31:58 -0700, George Anzinger wrote: I have been doing some work on kgdb to pull a few of it "fingers" out of various places in the kernel. This is the final location where we have a kgdb intercept not covered by a notify. I like the idea, but the

Re: [PATCH] NMI watch dog notify patch

2005-07-28 Thread Keith Owens
On Thu, 28 Jul 2005 13:31:58 -0700, George Anzinger wrote: >I have been doing some work on kgdb to pull a few of it "fingers" out of >various places in the kernel. This is the final location where we have >a kgdb intercept not covered by a notify. I like the idea, but the hook should be in di

Re: [PATCH] NMI watch dog notify patch

2005-07-28 Thread Andrew Morton
George Anzinger wrote: > > Andrew Morton wrote: > > George Anzinger wrote: > > > >>This patch adds a notify to the nmi watchdog to notify that > >>the system is about to be taken down by the watchdog. If the > >>notify is handled with a NOTIFY_STOP return, the system is > >>give

Re: [PATCH] NMI watch dog notify patch

2005-07-28 Thread George Anzinger
Andrew Morton wrote: George Anzinger wrote: This patch adds a notify to the nmi watchdog to notify that the system is about to be taken down by the watchdog. If the notify is handled with a NOTIFY_STOP return, the system is given a new lease on life. It look

Re: [PATCH] NMI watch dog notify patch

2005-07-28 Thread Andrew Morton
George Anzinger wrote: > > This patch adds a notify to the nmi watchdog to notify that > the system is about to be taken down by the watchdog. If the > notify is handled with a NOTIFY_STOP return, the system is > given a new lease on life. It looks sensible, but as there