Re: [PATCH] NFSD: hide unused svcxdr_dupstr()

2018-01-22 Thread J. Bruce Fields
On Fri, Jan 19, 2018 at 10:58:27PM +0100, Rasmus Villemoes wrote: > On 2018-01-19 15:54, Arnd Bergmann wrote: > > There is now only one caller left for svcxdr_dupstr() and this is inside > > of an #ifdef, so we can get a warning when the option is disabled: > > > > fs/nfsd/nfs4xdr.c:241:1: error:

Re: [PATCH] NFSD: hide unused svcxdr_dupstr()

2018-01-19 Thread Rasmus Villemoes
On 2018-01-19 15:54, Arnd Bergmann wrote: > There is now only one caller left for svcxdr_dupstr() and this is inside > of an #ifdef, so we can get a warning when the option is disabled: > > fs/nfsd/nfs4xdr.c:241:1: error: 'svcxdr_dupstr' defined but not used > [-Werror=unused-function] > > This

Re: [PATCH] NFSD: hide unused svcxdr_dupstr()

2018-01-19 Thread Bruce Fields
On Fri, Jan 19, 2018 at 11:15:33AM -0500, Chuck Lever wrote: > > > > On Jan 19, 2018, at 9:54 AM, Arnd Bergmann wrote: > > > > There is now only one caller left for svcxdr_dupstr() and this is inside > > of an #ifdef, so we can get a warning when the option is disabled: > > > > fs/nfsd/nfs4xdr

Re: [PATCH] NFSD: hide unused svcxdr_dupstr()

2018-01-19 Thread Chuck Lever
> On Jan 19, 2018, at 9:54 AM, Arnd Bergmann wrote: > > There is now only one caller left for svcxdr_dupstr() and this is inside > of an #ifdef, so we can get a warning when the option is disabled: > > fs/nfsd/nfs4xdr.c:241:1: error: 'svcxdr_dupstr' defined but not used > [-Werror=unused-func