Re: [PATCH] Move kfree_call_rcu() to slab_common.c

2018-01-02 Thread Paul E. McKenney
On Thu, Dec 21, 2017 at 07:17:35PM -0800, Rao Shoaib wrote: > > > On 12/21/2017 05:39 PM, Paul E. McKenney wrote: > >>I left it out on purpose because the call in tiny is a little different > >> > >>rcutiny.h: > >> > >>static inline void kfree_call_rcu(struct rcu_head *head, > >>                

Re: [PATCH] Move kfree_call_rcu() to slab_common.c

2017-12-21 Thread Paul E. McKenney
On Thu, Dec 21, 2017 at 09:31:23AM -0800, Rao Shoaib wrote: > > > On 12/21/2017 04:36 AM, Matthew Wilcox wrote: > >On Thu, Dec 21, 2017 at 12:19:47AM -0800, rao.sho...@oracle.com wrote: > >>This patch moves kfree_call_rcu() and related macros out of rcu code. A new > >>function __call_rcu_lazy()

Re: [PATCH] Move kfree_call_rcu() to slab_common.c

2017-12-21 Thread Paul E. McKenney
On Thu, Dec 21, 2017 at 05:27:41PM -0800, Paul E. McKenney wrote: > On Thu, Dec 21, 2017 at 09:06:28AM -0800, Matthew Wilcox wrote: > > On Thu, Dec 21, 2017 at 07:54:34AM -0800, Paul E. McKenney wrote: > > > > +/* Queue an RCU callback for lazy invocation after a grace period. > > > > + * Currently

Re: [PATCH] Move kfree_call_rcu() to slab_common.c

2017-12-21 Thread Paul E. McKenney
On Thu, Dec 21, 2017 at 09:06:28AM -0800, Matthew Wilcox wrote: > On Thu, Dec 21, 2017 at 07:54:34AM -0800, Paul E. McKenney wrote: > > > +/* Queue an RCU callback for lazy invocation after a grace period. > > > + * Currently there is no way of tagging the lazy RCU callbacks in the > > > + * list o

Re: [PATCH] Move kfree_call_rcu() to slab_common.c

2017-12-21 Thread Rao Shoaib
On 12/21/2017 04:36 AM, Matthew Wilcox wrote: On Thu, Dec 21, 2017 at 12:19:47AM -0800, rao.sho...@oracle.com wrote: This patch moves kfree_call_rcu() and related macros out of rcu code. A new function __call_rcu_lazy() is created for calling __call_rcu() with the lazy flag. Something you pro

Re: [PATCH] Move kfree_call_rcu() to slab_common.c

2017-12-21 Thread Matthew Wilcox
On Thu, Dec 21, 2017 at 07:54:34AM -0800, Paul E. McKenney wrote: > > +/* Queue an RCU callback for lazy invocation after a grace period. > > + * Currently there is no way of tagging the lazy RCU callbacks in the > > + * list of pending callbacks. Until then, this function may only be > > + * calle

Re: [PATCH] Move kfree_call_rcu() to slab_common.c

2017-12-21 Thread Paul E. McKenney
On Thu, Dec 21, 2017 at 12:19:47AM -0800, rao.sho...@oracle.com wrote: > From: Rao Shoaib > > This patch moves kfree_call_rcu() and related macros out of rcu code. I do very much like this idea! > A new > function __call_rcu_

Re: [PATCH] Move kfree_call_rcu() to slab_common.c

2017-12-21 Thread Matthew Wilcox
On Thu, Dec 21, 2017 at 12:19:47AM -0800, rao.sho...@oracle.com wrote: > This patch moves kfree_call_rcu() and related macros out of rcu code. A new > function __call_rcu_lazy() is created for calling __call_rcu() with the lazy > flag. Something you probably didn't know ... there are two RCU imple