Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-10 Thread Marco Colombo
On Wed, 10 Jan 2001, Linus Torvalds wrote: > > > On Wed, 10 Jan 2001, Marco Colombo wrote: > > > > > > case xxx: > > > /* fallthrough */ ; > > > } > > > > > > or something (or maybe just a "break" statement), just so that we don't > > > turn the poor C language into line noise (

Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-10 Thread Marco Colombo
On 10 Jan 2001, Alan Shutko wrote: > Marco Colombo <[EMAIL PROTECTED]> writes: > > > But what happens if I delete the stm1 line? We have: > > > > case xxx: > > /* fallthrough */ > > case yyy: > > stm2; > > > > which is wrong. > > AFAIK, that's perfectly correc

Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-10 Thread Linus Torvalds
On Wed, 10 Jan 2001, Marco Colombo wrote: > > > > case xxx: > > /* fallthrough */ ; > > } > > > > or something (or maybe just a "break" statement), just so that we don't > > turn the poor C language into line noise (can anybody say "perl" ;) > > Of course, you don't mean t

Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-10 Thread Alan Shutko
Marco Colombo <[EMAIL PROTECTED]> writes: > But what happens if I delete the stm1 line? We have: > > case xxx: > /* fallthrough */ > case yyy: > stm2; > > which is wrong. AFAIK, that's perfectly correct. It's only the case where you have a label at the

Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-10 Thread Marco Colombo
On Tue, 9 Jan 2001, Linus Torvalds wrote: > > > On Wed, 10 Jan 2001, Andrea Arcangeli wrote: > > > On Tue, Jan 09, 2001 at 01:31:35PM -0800, Linus Torvalds wrote: > > > don't have to worry about undocumented extensions etc. > > > > Infact I don't blame gcc maintainers for that, but the standa

Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-10 Thread Andrea Arcangeli
On Tue, Jan 09, 2001 at 11:10:37PM -0800, Linus Torvalds wrote: > I have to say, I think it was Pascal had this "no semicolon needed before > an 'end'" rule, and I always really hated that. The C statement rules make Me too ;) Andrea - To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-10 Thread Rich Baum
On 9 Jan 2001, at 23:10, Linus Torvalds wrote: > > > On Wed, 10 Jan 2001, Andrea Arcangeli wrote: > > > On Tue, Jan 09, 2001 at 01:31:35PM -0800, Linus Torvalds wrote: > > > don't have to worry about undocumented extensions etc. > > > > Infact I don't blame gcc maintainers for that, but the s

Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-09 Thread Linus Torvalds
On Wed, 10 Jan 2001, Andrea Arcangeli wrote: > On Tue, Jan 09, 2001 at 01:31:35PM -0800, Linus Torvalds wrote: > > don't have to worry about undocumented extensions etc. > > Infact I don't blame gcc maintainers for that, but the standard. Ok, minor > issue. Yeah, and nothing we can do about i

Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-09 Thread Andrea Arcangeli
On Tue, Jan 09, 2001 at 01:31:35PM -0800, Linus Torvalds wrote: > don't have to worry about undocumented extensions etc. Infact I don't blame gcc maintainers for that, but the standard. Ok, minor issue. Andrea - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-09 Thread Rich Baum
On 9 Jan 2001, at 10:51, Linus Torvalds wrote: > > > On Tue, 9 Jan 2001, Albert D. Cahalan wrote: > > > [about labels w/o statements after them] > > > > >> Is this really a kernel bug? This is common idiom in C, so gcc > > >> shouldn't warn about it. If it does, it is a bug in gcc IMHO. > >

Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-09 Thread Linus Torvalds
On Tue, 9 Jan 2001, Albert D. Cahalan wrote: > > > Let the gcc people fix the bugs they find without complaining about them. > > After all, gcc would have been perfectly correct in signalling this as a > > syntax error, and aborted compilation. The fact that gcc only warns about > > it is a sig

Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-09 Thread Albert D. Cahalan
Linus Torvalds writes: > On Tue, 9 Jan 2001, Albert D. Cahalan wrote: >> [about labels w/o statements after them] >> Is this really a kernel bug? This is common idiom in C, so gcc shouldn't warn about it. If it does, it is a bug in gcc IMHO. >>> >>> No, it is not a common idiom in C. I

Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-09 Thread Linus Torvalds
On Tue, 9 Jan 2001, Albert D. Cahalan wrote: > [about labels w/o statements after them] > > >> Is this really a kernel bug? This is common idiom in C, so gcc > >> shouldn't warn about it. If it does, it is a bug in gcc IMHO. > > > > No, it is not a common idiom in C. It has _never_ been valid

Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-09 Thread Richard B. Johnson
On Tue, 9 Jan 2001, Albert D. Cahalan wrote: > [about labels w/o statements after them] > > >> Is this really a kernel bug? This is common idiom in C, so gcc > >> shouldn't warn about it. If it does, it is a bug in gcc IMHO. > > > > No, it is not a common idiom in C. It has _never_ been valid C

Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-09 Thread Albert D. Cahalan
[about labels w/o statements after them] >> Is this really a kernel bug? This is common idiom in C, so gcc >> shouldn't warn about it. If it does, it is a bug in gcc IMHO. > > No, it is not a common idiom in C. It has _never_ been valid C. > > GCC originally allowed it due to a mistake in the gr

Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-08 Thread Richard Henderson
On Mon, Jan 08, 2001 at 08:50:01PM +0100, Erik Mouw wrote: > Is this really a kernel bug? This is common idiom in C, so gcc > shouldn't warn about it. If it does, it is a bug in gcc IMHO. No, it is not a common idiom in C. It has _never_ been valid C. GCC originally allowed it due to a mistake

Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-08 Thread Rich Baum
On 8 Jan 2001, at 20:50, Erik Mouw wrote: > On Sat, Jan 06, 2001 at 09:40:51PM -0500, Rich Baum wrote: > > Here's a patch that fixes more of the compile warnings with gcc > > 2.97. > > > -case FORE200E_STATE_BLANK: > > +case FORE200E_STATE_BLANK:; > > Is this really a kernel bug? This

Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-08 Thread Alan Cox
> > -case FORE200E_STATE_BLANK: > > +case FORE200E_STATE_BLANK:; > > Is this really a kernel bug? This is common idiom in C, so gcc > shouldn't warn about it. If it does, it is a bug in gcc IMHO. It's not valid in current ISO C. So gcc warns about it - To unsubscribe from this list: se

Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-08 Thread Erik Mouw
On Sat, Jan 06, 2001 at 09:40:51PM -0500, Rich Baum wrote: > Here's a patch that fixes more of the compile warnings with gcc > 2.97. > -case FORE200E_STATE_BLANK: > +case FORE200E_STATE_BLANK:; Is this really a kernel bug? This is common idiom in C, so gcc shouldn't warn about it. If it

Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-07 Thread Keith Owens
On Sun, 07 Jan 2001 07:41:57 -0500, Paul Gortmaker <[EMAIL PROTECTED]> wrote: >Rich Baum wrote: >> >> Here's a patch that fixes more of the compile warnings with gcc >> 2.97. >> -#endif __SNMP__ >> +#endif /* __SNMP__ */ > >Might as well automate it for all of these endif ones through the entire

Re: [PATCH] More compile warning fixes for 2.4.0

2001-01-07 Thread Paul Gortmaker
Rich Baum wrote: > > Here's a patch that fixes more of the compile warnings with gcc > 2.97. [...] > -#endif __SNMP__ > +#endif /* __SNMP__ */ Might as well automate it for all of these endif ones through the entire kernel (assuming you already haven't of course). Paul. ---