Re: [PATCH] MIPS: ralink: remove ralink_halt()

2018-03-21 Thread NeilBrown
On Wed, Mar 21 2018, James Hogan wrote: > On Tue, Mar 20, 2018 at 07:29:51PM +1100, NeilBrown wrote: >> >> ralink_halt() does nothing that machine_halt() >> doesn't already do, so it adds no value. >> >> It actually causes incorrect behaviour due to the >> "unreachable()" at the end. This tell

Re: [PATCH] MIPS: ralink: remove ralink_halt()

2018-03-21 Thread James Hogan
On Tue, Mar 20, 2018 at 07:29:51PM +1100, NeilBrown wrote: > > ralink_halt() does nothing that machine_halt() > doesn't already do, so it adds no value. > > It actually causes incorrect behaviour due to the > "unreachable()" at the end. This tell the compiler that the > end of the function will