Re: [PATCH] LLVMLinux: Remove warning about returning an uninitialized variable

2014-03-31 Thread H. Peter Anvin
On 03/31/2014 03:16 PM, Behan Webster wrote: >>> >> __compiletime_error traps at compile time rather than link time, which >> is what you want. > The idea is to remove the compile time warning that the return code > "prev" isn't initialized in the default case. Indicating that > wrong_size_cmpxchg

Re: [PATCH] LLVMLinux: Remove warning about returning an uninitialized variable

2014-03-31 Thread Behan Webster
On 03/31/14 15:11, H. Peter Anvin wrote: On 03/31/2014 03:10 PM, Behan Webster wrote: diff --git a/include/asm-generic/cmpxchg-local.h b/include/asm-generic/cmpxchg-local.h index d8d4c89..4c41bb8 100644 --- a/include/asm-generic/cmpxchg-local.h +++ b/include/asm-generic/cmpxchg-local.h @@ -41,6

Re: [PATCH] LLVMLinux: Remove warning about returning an uninitialized variable

2014-03-31 Thread H. Peter Anvin
On 03/31/2014 03:10 PM, Behan Webster wrote: >>> >>> diff --git a/include/asm-generic/cmpxchg-local.h >>> b/include/asm-generic/cmpxchg-local.h >>> index d8d4c89..4c41bb8 100644 >>> --- a/include/asm-generic/cmpxchg-local.h >>> +++ b/include/asm-generic/cmpxchg-local.h >>> @@ -41,6 +41,7 @@ static

Re: [PATCH] LLVMLinux: Remove warning about returning an uninitialized variable

2014-03-31 Thread Behan Webster
On 03/31/14 13:52, H. Peter Anvin wrote: On 03/21/2014 11:38 PM, beh...@converseincode.com wrote: From: Behan Webster Fix uninitialized return code in default case in cmpxchg-local.h This patch fixes the code to prevent an uninitialized return value that is detected when compiling with clang

Re: [PATCH] LLVMLinux: Remove warning about returning an uninitialized variable

2014-03-31 Thread H. Peter Anvin
On 03/21/2014 11:38 PM, beh...@converseincode.com wrote: > From: Behan Webster > > Fix uninitialized return code in default case in cmpxchg-local.h > > This patch fixes the code to prevent an uninitialized return value that is > detected > when compiling with clang. The bug produces numerous wa

Re: [PATCH] LLVMLinux: Remove warning about returning an uninitialized variable

2014-03-22 Thread Behan Webster
On 03/22/14 03:01, Arnd Bergmann wrote: On Saturday 22 March 2014, beh...@converseincode.com wrote: diff --git a/include/asm-generic/cmpxchg-local.h b/include/asm-generic/cmpxchg-local.h index d8d4c89..4c41bb8 100644 --- a/include/asm-generic/cmpxchg-local.h +++ b/include/asm-generic/cmpxchg-lo

Re: [PATCH] LLVMLinux: Remove warning about returning an uninitialized variable

2014-03-22 Thread Arnd Bergmann
On Saturday 22 March 2014, beh...@converseincode.com wrote: > diff --git a/include/asm-generic/cmpxchg-local.h > b/include/asm-generic/cmpxchg-local.h > index d8d4c89..4c41bb8 100644 > --- a/include/asm-generic/cmpxchg-local.h > +++ b/include/asm-generic/cmpxchg-local.h > @@ -41,6 +41,7 @@ static