Re: [PATCH] KVM: ioapic: fix NULL deref ioapic->lock

2017-01-03 Thread Wanpeng Li
2017-01-04 1:23 GMT+08:00 Paolo Bonzini : > > > On 03/01/2017 13:06, David Hildenbrand wrote: >>> >>> switch (cap->cap) { >>> case KVM_CAP_HYPERV_SYNIC: >>> -return kvm_hv_activate_synic(vcpu); >>> +if (!irqchip_in_kernel(vcpu->kvm)) >>> +return -EINVAL; >>> +

Re: [PATCH] KVM: ioapic: fix NULL deref ioapic->lock

2017-01-03 Thread Paolo Bonzini
On 03/01/2017 13:06, David Hildenbrand wrote: >> >> switch (cap->cap) { >> case KVM_CAP_HYPERV_SYNIC: >> -return kvm_hv_activate_synic(vcpu); >> +if (!irqchip_in_kernel(vcpu->kvm)) >> +return -EINVAL; >> +else > > You can simply drop the else and ret

Re: [PATCH] KVM: ioapic: fix NULL deref ioapic->lock

2017-01-03 Thread David Hildenbrand
Thanks, this is beautiful enough. :) Hmm, the combination of 6c7caebc26c5 ("KVM: introduce kvm->created_vcpus", 2016-06-16) and 4c5ea0a9cd02 ("locking/static_key: Fix concurrent static_key_slow_inc()", 2016-06-24) should have fixed it for good. Is the ENABLE_CAP necessary to reproduce? Then,

Re: [PATCH] KVM: ioapic: fix NULL deref ioapic->lock

2017-01-03 Thread Wanpeng Li
2017-01-03 17:27 GMT+08:00 Dmitry Vyukov : > On Mon, Jan 2, 2017 at 7:01 PM, Paolo Bonzini wrote: >> >> >> On 02/01/2017 11:17, Dmitry Vyukov wrote: >>> On Mon, Jan 2, 2017 at 11:09 AM, Paolo Bonzini wrote: On 01/01/2017 04:44, Wanpeng Li wrote: > From: Wanpeng Li > >

Re: [PATCH] KVM: ioapic: fix NULL deref ioapic->lock

2017-01-03 Thread Dmitry Vyukov
On Mon, Jan 2, 2017 at 7:01 PM, Paolo Bonzini wrote: > > > On 02/01/2017 11:17, Dmitry Vyukov wrote: >> On Mon, Jan 2, 2017 at 11:09 AM, Paolo Bonzini wrote: >>> >>> >>> >>> On 01/01/2017 04:44, Wanpeng Li wrote: From: Wanpeng Li This was reported by syzkaller: BUG: unab

Re: [PATCH] KVM: ioapic: fix NULL deref ioapic->lock

2017-01-02 Thread Wanpeng Li
2017-01-03 2:01 GMT+08:00 Paolo Bonzini : > > > On 02/01/2017 11:17, Dmitry Vyukov wrote: >> On Mon, Jan 2, 2017 at 11:09 AM, Paolo Bonzini wrote: >>> >>> >>> >>> On 01/01/2017 04:44, Wanpeng Li wrote: From: Wanpeng Li This was reported by syzkaller: BUG: unable to handle

Re: [PATCH] KVM: ioapic: fix NULL deref ioapic->lock

2017-01-02 Thread Paolo Bonzini
On 02/01/2017 11:17, Dmitry Vyukov wrote: > On Mon, Jan 2, 2017 at 11:09 AM, Paolo Bonzini wrote: >> >> >> >> On 01/01/2017 04:44, Wanpeng Li wrote: >>> From: Wanpeng Li >>> >>> This was reported by syzkaller: >>> >>> BUG: unable to handle kernel NULL pointer dereference at 01b0 >>>

Re: [PATCH] KVM: ioapic: fix NULL deref ioapic->lock

2017-01-02 Thread Dmitry Vyukov
On Mon, Jan 2, 2017 at 11:09 AM, Paolo Bonzini wrote: > > > > On 01/01/2017 04:44, Wanpeng Li wrote: > > From: Wanpeng Li > > > > This was reported by syzkaller: > > > > BUG: unable to handle kernel NULL pointer dereference at 01b0 > > IP: _raw_spin_lock+0xc/0x30 > > PGD 3e28eb067 > >

Re: [PATCH] KVM: ioapic: fix NULL deref ioapic->lock

2017-01-02 Thread Paolo Bonzini
On 01/01/2017 04:44, Wanpeng Li wrote: > From: Wanpeng Li > > This was reported by syzkaller: > > BUG: unable to handle kernel NULL pointer dereference at 01b0 > IP: _raw_spin_lock+0xc/0x30 > PGD 3e28eb067 > PUD 3f0ac6067 > PMD 0 > Oops: 0002 [#1] SMP > CPU: 0 PID: 2431 Comm: test