Re: Re: [PATCH] Input: omap-keypad - fix runtime pm imbalance on error

Fixing this in the PM core will influence all callers of pm_runtime_get_sync(). Therefore I think the better solution is to fix its misused callers. Regards, Dinghao "Dmitry Torokhov" 写道： > Hi Dinghao, > > On Wed, May 20, 2020 at 6:35 AM Dinghao Liu wrote: > > > > pm_

Re: [PATCH] Input: omap-keypad - fix runtime pm imbalance on error

On Wed, May 20, 2020 at 7:02 PM Dmitry Torokhov wrote: > > Hi Dinghao, > > On Wed, May 20, 2020 at 6:35 AM Dinghao Liu wrote: > > > > pm_runtime_get_sync() increments the runtime PM usage counter even > > the call returns an error code. Thus a pairing decrement is needed > > on the error handling

Re: [PATCH] Input: omap-keypad - fix runtime pm imbalance on error

Hi Dinghao, On Wed, May 20, 2020 at 6:35 AM Dinghao Liu wrote: > > pm_runtime_get_sync() increments the runtime PM usage counter even > the call returns an error code. Thus a pairing decrement is needed > on the error handling path to keep the counter balanced. This is a very surprising behavior