RE: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-31 Thread Philip Downey
ect: Re: [PATCH] IGMP: Inhibit reports for local multicast groups > > On Thu, Aug 27, 2015 at 8:46 AM, Philip Downey > wrote: > > IGMP reports for local multicast groups can now be optionally > > inhibited by means of a system control variable (by setting the value > > to

Re: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-28 Thread Cong Wang
On Thu, Aug 27, 2015 at 8:46 AM, Philip Downey wrote: > IGMP reports for local multicast groups can now be optionally > inhibited by means of a system control variable (by setting the value > to zero) e.g.: > echo 0 > /proc/sys/net/ipv4/igmp_link_local_mcast_reports > > To retain backwards com

Re: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-28 Thread David Miller
From: Philip Downey Date: Thu, 27 Aug 2015 16:46:26 +0100 > The range of addresses between 224.0.0.0 and 224.0.0.255 inclusive, is > reserved for the use of routing protocols and other low-level topology > discovery or maintenance protocols, such as gateway discovery and > group membership report

RE: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-26 Thread Philip Downey
rnel.org > Subject: Re: [PATCH] IGMP: Inhibit reports for local multicast groups > > From: Philip Downey > Date: Mon, 24 Aug 2015 12:39:17 +0100 > > > +extern int sysctl_igmp_link_local_reports; > ... > > +/* IGMP reports for link-local multicast groups are en

Re: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-25 Thread David Miller
From: Philip Downey Date: Mon, 24 Aug 2015 12:39:17 +0100 > +extern int sysctl_igmp_link_local_reports; ... > +/* IGMP reports for link-local multicast groups are enabled by default */ > +#define IGMP_ENABLE_LLM 1 > + > +int sysctl_igmp_link_local_reports __read_mostly = IGMP_ENABLE_LLM;

RE: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-14 Thread Philip Downey
Downey > Cc: David Miller; kuz...@ms2.inr.ac.ru; jmor...@namei.org; yoshfuji@linux- > ipv6.org; ka...@trash.net; linux-kernel@vger.kernel.org; > net...@vger.kernel.org > Subject: Re: [PATCH] IGMP: Inhibit reports for local multicast groups > > Hi Philip > > So with a bit of

Re: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-14 Thread Andrew Lunn
Hi Philip So with a bit of poking and prodding, we have a much better understanding as to why this is O.K. Maybe your next patch can quote the relevant RFCs and have a much fuller commit message? Thanks Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in t

RE: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-14 Thread Philip Downey
el@vger.kernel.org; > net...@vger.kernel.org > Subject: Re: [PATCH] IGMP: Inhibit reports for local multicast groups > > On Thu, Aug 13, 2015 at 04:52:32PM +, Philip Downey wrote: > > Hi Andrew > > IGMP snooping is designed to prevent hosts on a local network from >

RE: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-14 Thread Philip Downey
ler; kuz...@ms2.inr.ac.ru; jmor...@namei.org; > yoshf...@linux-ipv6.org; ka...@trash.net; linux-kernel@vger.kernel.org; > net...@vger.kernel.org > Subject: Re: [PATCH] IGMP: Inhibit reports for local multicast groups > > On Thu, Aug 13, 2015 at 07:01:37PM +0200, Andrew Lunn wrote:

Re: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-13 Thread Thadeu Lima de Souza Cascardo
On Thu, Aug 13, 2015 at 07:01:37PM +0200, Andrew Lunn wrote: > On Thu, Aug 13, 2015 at 04:52:32PM +, Philip Downey wrote: > > Hi Andrew > > IGMP snooping is designed to prevent hosts on a local network from > > receiving traffic for a multicast group they have not explicitly joined. > > Lin

Re: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-13 Thread Andrew Lunn
On Thu, Aug 13, 2015 at 04:52:32PM +, Philip Downey wrote: > Hi Andrew > IGMP snooping is designed to prevent hosts on a local network from receiving > traffic for a multicast group they have not explicitly joined. Link-Local > multicast traffic should not have an IGMP client since it is re

RE: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-13 Thread Philip Downey
> To: Philip Downey > Cc: David Miller; kuz...@ms2.inr.ac.ru; jmor...@namei.org; yoshfuji@linux- > ipv6.org; ka...@trash.net; linux-kernel@vger.kernel.org; > net...@vger.kernel.org > Subject: Re: [PATCH] IGMP: Inhibit reports for local multicast groups > > On Thu, Aug 13, 2015

Re: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-13 Thread Andrew Lunn
On Thu, Aug 13, 2015 at 02:48:23PM +, Philip Downey wrote: > Hi David > Thanks for taking the time to review and comment. > This is my first upstream request so please forgive any ignorance on my part. > I have added a new proposed commit wording below with a view to agreeing > the content

RE: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-13 Thread Philip Downey
; From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, August 13, 2015 12:45 AM > To: Philip Downey > Cc: kuz...@ms2.inr.ac.ru; jmor...@namei.org; yoshf...@linux-ipv6.org; > ka...@trash.net; linux-kernel@vger.kernel.org; net...@vger.kernel.org > Subject: Re: [PATCH] IGMP

Re: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-12 Thread David Miller
From: Philip Downey Date: Wed, 12 Aug 2015 17:13:53 +0100 > IGMP reports are generated for link local multicast groups (224.0.0.1 > - 224.0.0.255) used by the routing protocols such as RIP, OSPF etc. > In general routers do not generate reports for local multicast groups. > > IGMP reports for lo