Re: [PATCH] IB/qib: remove superfluous fallthrough statements

2020-08-25 Thread Joe Perches
On Tue, 2020-08-25 at 12:01 -0500, Gustavo A. R. Silva wrote: > On 8/25/20 11:47, Joe Perches wrote [] > You would have noticed this should be two patches. That's interpretational. > > I think your desire for micropatches is unnecessary. > > > You might be generalizing. My 'desire' here is justi

Re: [PATCH] IB/qib: remove superfluous fallthrough statements

2020-08-25 Thread Alex Dewar
On 25/08/2020 17:49, Gustavo A. R. Silva wrote: On 8/25/20 11:26, Joe Perches wrote: On Tue, 2020-08-25 at 11:19 -0500, Gustavo A. R. Silva wrote: On 8/25/20 10:51, Alex Dewar wrote: Commit 36a8f01cd24b ("IB/qib: Add congestion control agent implementation") erroneously marked a couple of swi

Re: [PATCH] IB/qib: remove superfluous fallthrough statements

2020-08-25 Thread Gustavo A. R. Silva
On 8/25/20 11:47, Joe Perches wrote: > On Tue, 2020-08-25 at 11:49 -0500, Gustavo A. R. Silva wrote: >> >> On 8/25/20 11:26, Joe Perches wrote: >>> On Tue, 2020-08-25 at 11:19 -0500, Gustavo A. R. Silva wrote: On 8/25/20 10:51, Alex Dewar wrote: > Commit 36a8f01cd24b ("IB/qib: Add conge

Re: [PATCH] IB/qib: remove superfluous fallthrough statements

2020-08-25 Thread Joe Perches
On Tue, 2020-08-25 at 11:49 -0500, Gustavo A. R. Silva wrote: > > On 8/25/20 11:26, Joe Perches wrote: > > On Tue, 2020-08-25 at 11:19 -0500, Gustavo A. R. Silva wrote: > > > On 8/25/20 10:51, Alex Dewar wrote: > > > > Commit 36a8f01cd24b ("IB/qib: Add congestion control agent > > > > implementat

Re: [PATCH] IB/qib: remove superfluous fallthrough statements

2020-08-25 Thread Gustavo A. R. Silva
On 8/25/20 11:26, Joe Perches wrote: > On Tue, 2020-08-25 at 11:19 -0500, Gustavo A. R. Silva wrote: >> >> On 8/25/20 10:51, Alex Dewar wrote: >>> Commit 36a8f01cd24b ("IB/qib: Add congestion control agent implementation") >>> erroneously marked a couple of switch cases as /* FALLTHROUGH */, whi

Re: [PATCH] IB/qib: remove superfluous fallthrough statements

2020-08-25 Thread Joe Perches
On Tue, 2020-08-25 at 11:19 -0500, Gustavo A. R. Silva wrote: > > On 8/25/20 10:51, Alex Dewar wrote: > > Commit 36a8f01cd24b ("IB/qib: Add congestion control agent implementation") > > erroneously marked a couple of switch cases as /* FALLTHROUGH */, which > > were later converted to fallthrough

Re: [PATCH] IB/qib: remove superfluous fallthrough statements

2020-08-25 Thread Gustavo A. R. Silva
On 8/25/20 10:51, Alex Dewar wrote: > Commit 36a8f01cd24b ("IB/qib: Add congestion control agent implementation") > erroneously marked a couple of switch cases as /* FALLTHROUGH */, which > were later converted to fallthrough statements by commit df561f6688fe > ("treewide: Use fallthrough pseudo