Re: [PATCH] GPIO: Add GPIO support for the ACCES 104-IDIO-16

2015-10-06 Thread Linus Walleij
On Tue, Oct 6, 2015 at 1:40 AM, William Breathitt Gray wrote: > On 10/05/2015 04:29 AM, Linus Walleij wrote: >>> +struct a_104_idio_16_gpio { >>> + struct gpio_chip chip; >>> + spinlock_t lock; >>> + unsigned base; >> >> Isn't this void __iomem *base? > > The 'base' member is use

Re: [PATCH] GPIO: Add GPIO support for the ACCES 104-IDIO-16

2015-10-06 Thread Linus Walleij
On Tue, Oct 6, 2015 at 1:11 AM, William Breathitt Gray wrote: > On 10/05/2015 06:47 PM, Bjorn Helgaas wrote: >> I'm really not familiar with PC/104, but wikipedia claims it only uses >> ISA. Apparently PCI/104-Plus, PCI-104, PCI/104-Express, and PCIe/104 >> *do* have PCI and/or PCIe, but it look

Re: [PATCH] GPIO: Add GPIO support for the ACCES 104-IDIO-16

2015-10-05 Thread William Breathitt Gray
On 10/05/2015 04:29 AM, Linus Walleij wrote: >> +struct a_104_idio_16_gpio { >> + struct gpio_chip chip; >> + spinlock_t lock; >> + unsigned base; > > Isn't this void __iomem *base? The 'base' member is used to hold the I/O port base address passed to the inb/outb functions for

Re: [PATCH] GPIO: Add GPIO support for the ACCES 104-IDIO-16

2015-10-05 Thread William Breathitt Gray
On 10/05/2015 06:47 PM, Bjorn Helgaas wrote: > I'm really not familiar with PC/104, but wikipedia claims it only uses > ISA. Apparently PCI/104-Plus, PCI-104, PCI/104-Express, and PCIe/104 > *do* have PCI and/or PCIe, but it looks like the base PC/104 does not. > > Bjorn > This is correct: PC/1

Re: [PATCH] GPIO: Add GPIO support for the ACCES 104-IDIO-16

2015-10-05 Thread Bjorn Helgaas
Hi William and Linus, On Mon, Oct 5, 2015 at 3:29 AM, Linus Walleij wrote: > On Thu, Oct 1, 2015 at 3:58 AM, William Breathitt Gray > wrote: > >> The ACCES 104-IDIO-16 family of PC/104 utility boards > > Sounds like a PC104 keyboard :D > >> feature 16 >> optically isolated inputs and 16 opticall

Re: [PATCH] GPIO: Add GPIO support for the ACCES 104-IDIO-16

2015-10-05 Thread Linus Walleij
On Thu, Oct 1, 2015 at 3:58 AM, William Breathitt Gray wrote: > The ACCES 104-IDIO-16 family of PC/104 utility boards Sounds like a PC104 keyboard :D > feature 16 > optically isolated inputs and 16 optically isolated FET solid state > outputs. This driver provides GPIO support for these 32 chan

Re: [PATCH] GPIO: Add GPIO support for the ACCES 104-IDIO-16

2015-10-02 Thread kbuild test robot
Hi William, [auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore] config: microblaze-allmodconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x