Re: [PATCH] GMAC: fix simple_return.cocci warnings

2015-01-05 Thread David Miller
From: Roger Date: Tue, 06 Jan 2015 15:13:39 +0800 > What should I do now? Nothing, I'm simply not applying this patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/m

Re: [PATCH] GMAC: fix simple_return.cocci warnings

2015-01-05 Thread Joe Perches
On Tue, 2015-01-06 at 15:13 +0800, Roger wrote: > What should I do now? I think it would be better to change "int gmac_clk_enable" to "void gmac_clk_enable" (it always returns 0) This function should simply call gmac_clk_enable and return 0; > >>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-

Re: [PATCH] GMAC: fix simple_return.cocci warnings

2015-01-05 Thread Roger
Hi! David What should I do now? On 2015/1/5 11:20, David Miller wrote: From: Joe Perches Date: Fri, 02 Jan 2015 16:46:45 -0800 On Sat, 2015-01-03 at 08:25 +0800, kbuild test robot wrote: drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:425:1-4: WARNING: end returns can be simpified Simpli

Re: [PATCH] GMAC: fix simple_return.cocci warnings

2015-01-04 Thread David Miller
From: Joe Perches Date: Fri, 02 Jan 2015 16:46:45 -0800 > On Sat, 2015-01-03 at 08:25 +0800, kbuild test robot wrote: >> drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:425:1-4: WARNING: end returns >> can be simpified >> >> Simplify a trivial if-return sequence. Possibly combine with a >> pr

Re: [PATCH] GMAC: fix simple_return.cocci warnings

2015-01-02 Thread Joe Perches
On Sat, 2015-01-03 at 08:25 +0800, kbuild test robot wrote: > drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:425:1-4: WARNING: end returns > can be simpified > > Simplify a trivial if-return sequence. Possibly combine with a > preceding function call. > Generated by: scripts/coccinelle/misc/si