Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup

2007-10-05 Thread Bernardo Innocenti
On 10/05/2007 09:15 AM, Pavel Machek wrote: This patch merges the fb_powerup and fb_powerdown hooks in a single operation fb_power with an additional "state" parameter ranging from 0 (running) to 3 (poweroff). No, please don't. Having int with 0/3 being valid specifying what to do is evil. en

Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup

2007-10-05 Thread Pavel Machek
Hi! > This patch merges the fb_powerup and fb_powerdown hooks in a single > operation fb_power with an additional "state" parameter ranging > from 0 (running) to 3 (poweroff). No, please don't. Having int with 0/3 being valid specifying what to do is evil. enum is less evil, but what's wrong abo