Re: [PATCH] Fix platform data in leds-pca955x.c

2018-07-05 Thread Jacek Anaszewski
Hi Rob. On 07/04/2018 02:46 AM, Rob Landley wrote: I have some questions about recent changes to leds-pca955x.c since 4.13: How is non-of platform data supposed to work now? Commit ed1f4b9676a8 switched struct led_platform_data *pdata in the _probe() function to a locally defined structure that

Re: [PATCH] Fix platform data in leds-pca955x.c

2018-07-04 Thread Andy Shevchenko
On Wed, Jul 4, 2018 at 9:09 PM, Rob Landley wrote: > On 07/04/2018 12:04 PM, Andy Shevchenko wrote: >> On Wed, Jul 4, 2018 at 8:00 PM, Andy Shevchenko >> wrote: >>> On Wed, Jul 4, 2018 at 3:46 AM, Rob Landley wrote: >> >>> For now, you can switch to unified device properties API (basically >>> u

Re: [PATCH] Fix platform data in leds-pca955x.c

2018-07-04 Thread Andy Shevchenko
On Wed, Jul 4, 2018 at 8:59 PM, Rob Landley wrote: > On 07/04/2018 12:00 PM, Andy Shevchenko wrote: >> On Wed, Jul 4, 2018 at 3:46 AM, Rob Landley wrote: >> No platform data, please. > > Why? Many reasons, starting with "no board files" approach. Main reason for this particular topic is _unific

Re: [PATCH] Fix platform data in leds-pca955x.c

2018-07-04 Thread Rob Landley
On 07/04/2018 12:04 PM, Andy Shevchenko wrote: > On Wed, Jul 4, 2018 at 8:00 PM, Andy Shevchenko > wrote: >> On Wed, Jul 4, 2018 at 3:46 AM, Rob Landley wrote: > >> For now, you can switch to unified device properties API (basically >> un-ifdef pca955x_pdata_of_init() and replacing of_* by devic

Re: [PATCH] Fix platform data in leds-pca955x.c

2018-07-04 Thread Rob Landley
On 07/04/2018 12:00 PM, Andy Shevchenko wrote: > On Wed, Jul 4, 2018 at 3:46 AM, Rob Landley wrote: >> I have some questions about recent changes to leds-pca955x.c since 4.13: >> >> How is non-of platform data supposed to work now? Commit ed1f4b9676a8 >> switched >> struct led_platform_data *p

Re: [PATCH] Fix platform data in leds-pca955x.c

2018-07-04 Thread Andy Shevchenko
On Wed, Jul 4, 2018 at 8:00 PM, Andy Shevchenko wrote: > On Wed, Jul 4, 2018 at 3:46 AM, Rob Landley wrote: > For now, you can switch to unified device properties API (basically > un-ifdef pca955x_pdata_of_init() and replacing of_* by device_* or > fwnode_* compatible calls) and providing a stat

Re: [PATCH] Fix platform data in leds-pca955x.c

2018-07-04 Thread Andy Shevchenko
On Wed, Jul 4, 2018 at 3:46 AM, Rob Landley wrote: > I have some questions about recent changes to leds-pca955x.c since 4.13: > > How is non-of platform data supposed to work now? Commit ed1f4b9676a8 switched > struct led_platform_data *pdata in the _probe() function to a locally defined > structu