Re: [PATCH] Fix error-code overwrite bug

2015-01-07 Thread Andy Shevchenko
On Wed, Jan 7, 2015 at 9:52 PM, Giel van Schijndel wrote: > On Wed, Jan 07, 2015 at 20:37:29 +0200, Andy Shevchenko wrote: >> On Sun, Jan 4, 2015 at 8:04 PM, Giel van Schijndel wrote: >>> Don't overwrite the returned error code with the boolean test used by >>> the if-statement (otherwise it'd be

Re: [PATCH] Fix error-code overwrite bug

2015-01-07 Thread Giel van Schijndel
On Wed, Jan 07, 2015 at 20:37:29 +0200, Andy Shevchenko wrote: > On Sun, Jan 4, 2015 at 8:04 PM, Giel van Schijndel wrote: >> Don't overwrite the returned error code with the boolean test used by >> the if-statement (otherwise it'd be 1 or 0 always, 1 in the if-block). >> --- >> drivers/mtd/nftlm

Re: [PATCH] Fix error-code overwrite bug

2015-01-07 Thread Andy Shevchenko
On Sun, Jan 4, 2015 at 8:04 PM, Giel van Schijndel wrote: > Don't overwrite the returned error code with the boolean test used by > the if-statement (otherwise it'd be 1 or 0 always, 1 in the if-block). > --- > drivers/mtd/nftlmount.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > di

Re: [PATCH] Fix error-code overwrite bug

2015-01-04 Thread Giel van Schijndel
On Sun, Jan 04, 2015 at 19:04:22 +0100, Giel van Schijndel wrote: > Don't overwrite the returned error code with the boolean test used by > the if-statement (otherwise it'd be 1 or 0 always, 1 in the if-block). > --- Forgot to: Signed-off-by: Giel van Schijndel -- Met vriendelijke groet, With k