Re: [PATCH] FUTEX : new PRIVATE futexes

2007-04-06 Thread Jan Engelhardt
On Apr 6 2007 07:05, Hugh Dickins wrote: >On Fri, 6 Apr 2007, Nick Piggin wrote: >> >> I like |= for adding flags, it seems less ambiguous. But I guess that's >> a matter of opinion. Hugh seems to like +=, > >Do I? You probably have a shaming example in mind (PAGE_MAPPING_ANON? >that's a hybrid

Re: [PATCH] FUTEX : new PRIVATE futexes

2007-04-06 Thread Peter Zijlstra
On Thu, 2007-04-05 at 19:49 +0200, Eric Dumazet wrote: > Hi all > > I'm pleased to present this patch which improves linux futexes performance > and > scalability, merely avoiding taking mmap_sem rwlock. > > Ulrich agreed with the API and said glibc work could start as soon > as he gets a Fedor

Re: [PATCH] FUTEX : new PRIVATE futexes

2007-04-06 Thread Nick Piggin
Eric Dumazet wrote: Nick Piggin a écrit : Did the whole thing just turn out neater when you passed the rwsem? We always know to use current->mm->mmap_sem, so it doesn't seem like a boolean flag would hurt? That's a good question current->mm->mmap_sem being calculated once is a win in itsel

Re: [PATCH] FUTEX : new PRIVATE futexes

2007-04-05 Thread Hugh Dickins
On Fri, 6 Apr 2007, Nick Piggin wrote: > > I like |= for adding flags, it seems less ambiguous. But I guess that's > a matter of opinion. Hugh seems to like +=, Do I? You probably have a shaming example in mind (PAGE_MAPPING_ANON? that's a hybrid case where using + and - helped minimize the cast

Re: [PATCH] FUTEX : new PRIVATE futexes

2007-04-05 Thread Eric Dumazet
Nick Piggin a écrit : Hi Eric, Thanks for doing this... It's looking good, I just have some minor comments: Hi Nick, thanks for reviewing. Eric Dumazet wrote: */ -int get_futex_key(void __user *uaddr, union futex_key *key) +int get_futex_key(void __user *uaddr, union futex_key *key, +

Re: [PATCH] FUTEX : new PRIVATE futexes

2007-04-05 Thread Nick Piggin
Hi Eric, Thanks for doing this... It's looking good, I just have some minor comments: Eric Dumazet wrote: Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> --- linux-2.6.21-rc5-mm4/kernel/futex.c +++ linux-2.6.21-rc5-mm4-ed/kernel/futex.c @@ -16,6 +16,9 @@ * Copyright (C) 2006 Red Hat, Inc

Re: [PATCH] FUTEX : new PRIVATE futexes

2007-04-05 Thread Ulrich Drepper
On 4/5/07, Eric Dumazet <[EMAIL PROTECTED]> wrote: Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> --- include/linux/futex.h | 45 +- kernel/futex.c| 294 +--- 2 files changed, 230 insertions(+), 109 deletions(-) I cannot vouch for the whole