Re: [PATCH] Export handle_mm_fault to modules.

2005-08-08 Thread Linus Torvalds
On Mon, 8 Aug 2005, Arnd Bergmann wrote: > > We will need the same export on ppc64 for managing SPEs on the > Cell processor. My current patch removes the export on ppc > and adds a global (*_GPL) one. Should I rather have another > architecture specific export in ppc64? I don't see any reason

Re: [PATCH] Export handle_mm_fault to modules.

2005-08-08 Thread Arnd Bergmann
On Sünnavend 06 August 2005 01:43, Linus Torvalds wrote: > diff --git a/arch/ppc/kernel/ppc_ksyms.c b/arch/ppc/kernel/ppc_ksyms.c > --- a/arch/ppc/kernel/ppc_ksyms.c > +++ b/arch/ppc/kernel/ppc_ksyms.c > @@ -324,7 +324,7 @@ EXPORT_SYMBOL(__res); >   >  EXPORT_SYMBOL(next_mmu_context); >  EXPORT_SYM

Re: [PATCH] Export handle_mm_fault to modules.

2005-08-06 Thread Stelian Pop
Le vendredi 05 août 2005 à 16:43 -0700, Linus Torvalds a écrit : > > On Fri, 5 Aug 2005, Olof Johansson wrote: > > > > On Fri, Aug 05, 2005 at 04:02:13PM -0700, Linus Torvalds wrote: > > > > > The only thing that has ever exported it afaik is > > > > > > arch/ppc/kernel/ppc_ksyms.c:EXPORT_SYMB

Re: [PATCH] Export handle_mm_fault to modules.

2005-08-05 Thread Linus Torvalds
On Fri, 5 Aug 2005, Olof Johansson wrote: > > On Fri, Aug 05, 2005 at 04:02:13PM -0700, Linus Torvalds wrote: > > > The only thing that has ever exported it afaik is > > > > arch/ppc/kernel/ppc_ksyms.c:EXPORT_SYMBOL(handle_mm_fault); /* For MOL > > */ > > > > and that looks pretty suspici

Re: [PATCH] Export handle_mm_fault to modules.

2005-08-05 Thread Olof Johansson
On Fri, Aug 05, 2005 at 04:02:13PM -0700, Linus Torvalds wrote: > The only thing that has ever exported it afaik is > > arch/ppc/kernel/ppc_ksyms.c:EXPORT_SYMBOL(handle_mm_fault); /* For MOL > */ > > and that looks pretty suspicious too (what is MOL, and regardless, > shouldn't it be an

Re: [PATCH] Export handle_mm_fault to modules.

2005-08-05 Thread Linus Torvalds
On Fri, 5 Aug 2005, Stelian Pop wrote: > > handle_mm_fault changed from an inline function to a non-inline one > (__handle_mm_fault), which is not available to external kernel modules. > The patch below fixes this. We didn't use to export handle_mm_fault before, and it wasn't an inline function

Re: [PATCH] Export handle_mm_fault to modules.

2005-08-05 Thread Dave Jones
On Fri, Aug 05, 2005 at 11:55:12PM +0200, Stelian Pop wrote: > handle_mm_fault changed from an inline function to a non-inline one > (__handle_mm_fault), which is not available to external kernel modules. > The patch below fixes this. > > Stelian. > > Export __handle_mm_fault to modules (c