Re: [PATCH] EDAC, pnd2_edac: make function sbi_send static

2017-06-26 Thread Borislav Petkov
On Fri, Jun 23, 2017 at 09:48:55AM +0100, Colin King wrote: > From: Colin Ian King > > The function sbi_send is local to just pnd2_edac.c and does not need to > be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'sbi_send' was not declared. Should it be static? > > Si

Re: [PATCH] EDAC, pnd2_edac: make function sbi_send static

2017-06-23 Thread Luck, Tony
On Fri, Jun 23, 2017 at 10:58:24AM +0200, Borislav Petkov wrote: > On Fri, Jun 23, 2017 at 09:48:55AM +0100, Colin King wrote: > > From: Colin Ian King > > -int sbi_send(int port, int off, int op, u32 *data) > > +static int sbi_send(int port, int off, int op, u32 *data) > > Tony, were those suppo

Re: [PATCH] EDAC, pnd2_edac: make function sbi_send static

2017-06-23 Thread Borislav Petkov
On Fri, Jun 23, 2017 at 09:48:55AM +0100, Colin King wrote: > From: Colin Ian King > > The function sbi_send is local to just pnd2_edac.c and does not need to > be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'sbi_send' was not declared. Should it be static? > > Si